From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 048333858C50 for ; Wed, 8 May 2024 22:54:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 048333858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 048333858C50 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1715208890; cv=pass; b=uCNs+lM7w1dQICHuGpG1kQOhm9baDeabnKVnF5HFSwU1fI3MvxIcH5h/hsFmAO+9pVW/nRmBDiwOWoK2yAgGc0LurEP5lovA9t9PX0KaFzzlQmCM2OfOiKRN/GDB03mJdCBPOFNUSzpJx1q8GDmczeU5MrhLQuwlXwiExc0QNCc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1715208890; c=relaxed/simple; bh=pM0wbwva+xiS5mliXiNl06PpWmXB1GOtvMrgBqZlisM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=b0rz+N9cs4ISVRoy4mSBjUuFEADoV+5XF+WIiyMutcRoiUQa4CQ6EhBe8p9EQkHLPZj1Rpf9hjcHcT8Mhvka1hPsxh+zcoq+vu3dQjsNLmqk4adZGeYG24d5eeR4MMCrEGQB8z5B/dWoMpakjFxBQ0vdo4RjNp3MSa15RB+N62I= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4VZVpJ61YBz43Rp; Wed, 8 May 2024 22:54:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VZVpJ51zMz4c1w; Wed, 8 May 2024 22:54:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715208888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QmPcb6G5Oo/j3Ey9CLP2hFj1m4h/xqR3kAqukvcE4Mo=; b=xjAdbvLh2mcUk7RfoQqc4UqHrjSb4WJn1bwx/yZYeLj9yhUbXUJIVsdWBbmu362s7b7u/7 Bv2scqw9HO/xrjvdtrYjX3Wt+ghz98SCv03LMeREhSQtm3SjS6LsnPZ5Sx27INixQeu4u8 H4kK8w8WcQ7chWlTU6ipqB97PYW3VuIw77ct1vWX3NUt9TWFEC4zIKCmJEqL4F1hb4RekC xdiHuLYv30a6b9tliJwI5KZrJDTYjCnY/KqAmnN1waQLFlBwohYG+S2MxJNTnuzIC6vxr3 +arWBtfWXjk6qrp37hNeL2Mn+piB/FCWj6zaUI/z7/MGVVVSp7NzII9yM9EU2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715208888; a=rsa-sha256; cv=none; b=RvyAqrsT3GtE5A41fGvmPax8IGOWKAgSnSlCOen8idk8u7ccDVZVMNtnounCRnTfcBrzns JYOj/aYVVWO0MKyNDLHG7BUG8Fl3AVcPz5+hxnZ/dEQawFjdEwatO+uUb7jl2qHcYyGXe0 LU/gqY7mpXFUX5gOlpHumpv6jAkf7WqpKzfUfhrJiC3ZJ+/En0rX0c4xfPS0kAUsSY89+a LT0v7iA7JcRn6KqaPmwq0WiKMq4oRNBoW9TCwSMluGFJg16hFJwdY/CqwF1AaijxWfeA7+ mFAAyL81Vd18JAIl5Lm+K+1u8gXeG7u0ZRN2N3yCHxxsHXcf9rOfmhIQC4lAZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715208888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QmPcb6G5Oo/j3Ey9CLP2hFj1m4h/xqR3kAqukvcE4Mo=; b=hnIlc3ukBrCWmZsqTd0BIg1KtNuAmo0PX8JkLPp3BPT05Mz/CKSPoZu264JSyTqS09a/4n fSw1Yq8KK7cEAscM2GEK29OvnMspCnZB3lddxaoHvXtNgwH1Wq3Nzo4QnClTssmvJ/hpSY X1WiQhBOqW16dQaOU3AwVzo5vqRtHBICBKDAztcx8wG2fHr9MornG7ge7hcrCJgQFUURYK 3ETqnoHMDifwn7/vshpYkq1HQ6uLfwk1bVc/EGtHU6zvrnL0ttbJqtR86TyBx9oCVYmvhe lywFkYwOZ8MbnjoeHQyUTRvimdZivk/HBhkFlOc9Dq8cquL8m4cDuoU+JTtiBA== Received: from [IPV6:2601:644:937f:4c50:495d:378a:79e0:455] (unknown [IPv6:2601:644:937f:4c50:495d:378a:79e0:455]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VZVpJ26Yjz1RJ6; Wed, 8 May 2024 22:54:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 8 May 2024 15:54:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv6 6/9] gdb: move xcr0 == 0 check into i386_linux_core_read_description Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org Cc: felix.willgerodt@intel.com References: From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/8/24 9:46 AM, Andrew Burgess wrote: > Currently, in i386_linux_core_read_description, if GDB fails to > extract an xcr0 value from the core file, then we will have a default > zero value for the xcr0 variable, we still call the > i386_linux_read_description function, which checks for this zero value > and returns nullptr. > > Back in i386_linux_core_read_description we spot the nullptr return > value from i386_linux_read_description and call > i386_linux_read_description again, but this time passing a default > value for xcr0. > > In the next commit I plan to rework i386_linux_read_description, and > in so doing I will remove the check for xcr0 == 0, this is inline with > how the amd64 code is written. > > However, this means that the 'xcr0 == 0' check needs to move up the > stack to i386_linux_core_read_description, again, this brings the i386 > code into line with the amd64 code. > > This is just a refactor in preparation for the next commit, there > should be no user visible changes after this commit. > > Approved-By: Felix Willgerodt Approved-By: John Baldwin -- John Baldwin