* [PATCH] Don't redefine upload/download/file in gdbserver-base
@ 2018-03-01 13:25 Simon Marchi
2018-03-08 22:56 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Simon Marchi @ 2018-03-01 13:25 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
From: Simon Marchi <simon.marchi@polymtl.ca>
Before patch
Make native gdbserver boards no longer be "remote" (in DejaGnu terms)
739b3f1d8ff7072dcc66240c25b026c6433bda1a
the local gdbserver boards (except native-extended-gdbserver...) were
considered as remote by DejaGNU. To avoid DejaGNU trying to use ssh/scp
to download the files to the target (which is actually local), the
gdbserver-base.exp file defined some _download, _upload and _file board
operations to override the default behavior, and instead just use local
operations.
The same patch also changed remote-stdio-gdbserver.exp to make it
inherit from gdbserver-base.exp. Since then, this board (which is
actually remote) uses the overrides with local file operations. As a
result, files are never actually copied to the target.
I think we can simply remove the overrides from gdbserver-base.exp.
Because all boards should be properly considered local or remote by
DejaGNU, it should by default use the right method for transferring
files.
gdb/testsuite/ChangeLog:
PR gdb/22841
* boards/gdbserver-base.exp (${board}_file, ${board}_download,
${board}_upload): Remove.
---
gdb/testsuite/boards/gdbserver-base.exp | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/gdb/testsuite/boards/gdbserver-base.exp b/gdb/testsuite/boards/gdbserver-base.exp
index 2e97697..52ad698 100644
--- a/gdb/testsuite/boards/gdbserver-base.exp
+++ b/gdb/testsuite/boards/gdbserver-base.exp
@@ -32,25 +32,3 @@ set_board_info gdb,nofileio 1
set_board_info gdb,predefined_tsv "\\\$trace_timestamp"
set GDBFLAGS "${GDBFLAGS} -ex \"set auto-connect-native-target off\""
-
-proc ${board}_file { dest op args } {
- if { $op == "delete" } {
- return 0
- }
- return [eval [list standard_file $dest $op] $args]
-}
-
-proc ${board}_download { board host dest } {
- # We pass DEST in standard_output_file, regardless of whether it is absolute
- # or relative, because we don't want the tests to be able to write outside
- # their standard output directory.
- set dest [standard_output_file $dest]
-
- file copy -force $host $dest
-
- return $dest
-}
-
-proc ${board}_upload {dest srcfile args} {
- return $srcfile
-}
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Don't redefine upload/download/file in gdbserver-base
2018-03-01 13:25 [PATCH] Don't redefine upload/download/file in gdbserver-base Simon Marchi
@ 2018-03-08 22:56 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2018-03-08 22:56 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
On 2018-03-01 08:24, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> Before patch
>
> Make native gdbserver boards no longer be "remote" (in DejaGnu terms)
> 739b3f1d8ff7072dcc66240c25b026c6433bda1a
>
> the local gdbserver boards (except native-extended-gdbserver...) were
> considered as remote by DejaGNU. To avoid DejaGNU trying to use
> ssh/scp
> to download the files to the target (which is actually local), the
> gdbserver-base.exp file defined some _download, _upload and _file board
> operations to override the default behavior, and instead just use local
> operations.
>
> The same patch also changed remote-stdio-gdbserver.exp to make it
> inherit from gdbserver-base.exp. Since then, this board (which is
> actually remote) uses the overrides with local file operations. As a
> result, files are never actually copied to the target.
>
> I think we can simply remove the overrides from gdbserver-base.exp.
> Because all boards should be properly considered local or remote by
> DejaGNU, it should by default use the right method for transferring
> files.
I pushed this patch.
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-08 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01 13:25 [PATCH] Don't redefine upload/download/file in gdbserver-base Simon Marchi
2018-03-08 22:56 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).