From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix scoped_ignore_sigpipe selftest on systems with BSD signal semantics
Date: Tue, 22 Jun 2021 20:00:31 +0100 [thread overview]
Message-ID: <ae448dc2-67cc-0246-4c29-19b38cf3f2ba@palves.net> (raw)
In-Reply-To: <87a6niuhzs.fsf@tromey.com>
On 2021-06-22 2:49 p.m., Tom Tromey wrote:
> Pedro> Fix this by using sigaction. I'm not adding the usual #ifdef
> Pedro> HAVE_SIGACTION goo, because I really want to believe that all systems
> Pedro> that support SIGPIPE support sigaction nowadays. GNU/Linux, Hurd,
> Pedro> BSDs, macOS, Cygwin, DJGPP, AIX, etc., anything resembling a modern
> Pedro> Unix does support it AFAIK, only mingw does not support it, but OTOH,
> Pedro> it also doesn't define SIGPIPE. Confirmed by cross building GDB for
> Pedro> mingw-w64.
>
> gnulib seems to agree:
>
> https://www.gnu.org/software/gnulib/manual/html_node/sigprocmask.html
>
Thanks, I didn't remember to check that. That's the sigprocmask page, but the sigaction one
(which no doubt you meant to paste) is similar.
> Pedro> We could probably remove the HAVE_SIGPROCMASK check too, actually.
>
> Sounds good.
I'll try to remember to do that soon.
prev parent reply other threads:[~2021-06-22 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 18:55 Pedro Alves
2021-06-17 21:05 ` John Baldwin
2021-06-17 21:23 ` [pushed] Fix scoped_ignore_sigpipe selftest on systems with SysV " Pedro Alves
2021-06-22 13:49 ` [PATCH] Fix scoped_ignore_sigpipe selftest on systems with BSD " Tom Tromey
2021-06-22 19:00 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae448dc2-67cc-0246-4c29-19b38cf3f2ba@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).