From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/3] gdb/amdgpu: add precise-memory support
Date: Thu, 14 Sep 2023 12:43:50 -0400 [thread overview]
Message-ID: <ae59bd8c-8b02-4f7d-a107-5caecb41e038@polymtl.ca> (raw)
In-Reply-To: <83il8clne0.fsf@gnu.org>
On 9/14/23 12:39, Eli Zaretskii via Gdb-patches wrote:
>> Cc: Simon Marchi <simon.marchi@efficios.com>
>> Date: Thu, 14 Sep 2023 12:14:19 -0400
>> From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
>>
>> gdb/amd-dbgapi-target.c | 173 +++++++++++++++++-
>> gdb/doc/gdb.texinfo | 43 +++++
>> gdb/testsuite/gdb.rocm/precise-memory-exec.c | 44 +++++
>> .../gdb.rocm/precise-memory-exec.exp | 58 ++++++
>> gdb/testsuite/gdb.rocm/precise-memory-fork.c | 41 +++++
>> .../gdb.rocm/precise-memory-fork.exp | 50 +++++
>> .../precise-memory-multi-inferiors.exp | 87 +++++++++
>> .../precise-memory-warning-sigsegv.cpp | 33 ++++
>> .../precise-memory-warning-sigsegv.exp | 45 +++++
>> gdb/testsuite/gdb.rocm/precise-memory.cpp | 32 ++++
>> gdb/testsuite/gdb.rocm/precise-memory.exp | 57 ++++++
>> gdb/testsuite/lib/rocm.exp | 19 ++
>> 12 files changed, 677 insertions(+), 5 deletions(-)
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-exec.c
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-exec.exp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-fork.c
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-fork.exp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.cpp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory.cpp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory.exp
>
> Thanks.
>
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index 9b7e06f31566..aa3c67788871 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>
> This part is OK.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Thanks,
Simon
next prev parent reply other threads:[~2023-09-14 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 16:14 [PATCH v2 1/3] gdb: add inferior_cloned observable Simon Marchi
2023-09-14 16:14 ` [PATCH v2 2/3] gdb/testsuite: add linux target check in allow_hipcc_tests Simon Marchi
2023-09-14 16:14 ` [PATCH v2 3/3] gdb/amdgpu: add precise-memory support Simon Marchi
2023-09-14 16:39 ` Eli Zaretskii
2023-09-14 16:43 ` Simon Marchi [this message]
2023-09-15 10:13 ` Lancelot SIX
2023-09-15 14:47 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae59bd8c-8b02-4f7d-a107-5caecb41e038@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).