From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130568 invoked by alias); 9 Aug 2018 13:28:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130557 invoked by uid 89); 9 Aug 2018 13:28:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:747 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 13:28:13 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A81C640216EC; Thu, 9 Aug 2018 13:28:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 562FB10AF9D7; Thu, 9 Aug 2018 13:28:10 +0000 (UTC) Subject: Re: gdb build problem (gdb/unittests/scoped_mmap-selftests.c) To: Tom Tromey , Simon Marchi References: <1533742957.31481.2.camel@cavium.com> <87wot092xy.fsf@tromey.com> <87sh3o91y2.fsf@tromey.com> Cc: Steve Ellcey , gdb-patches , simon.marchi@ericsson.com From: Pedro Alves Message-ID: Date: Thu, 09 Aug 2018 13:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87sh3o91y2.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00211.txt.bz2 On 08/08/2018 06:56 PM, Tom Tromey wrote: > diff --git a/gdb/configure.ac b/gdb/configure.ac > index 13bc5f9a8f2..76a1ba0364f 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -2279,6 +2279,10 @@ dnl At the moment, we just assume it's UTF-8. > AC_DEFINE(GDB_DEFAULT_HOST_CHARSET, "UTF-8", > [Define to be a string naming the default host character set.]) > > +AH_BOTTOM([#if defined __OPTIMIZE__ && __OPTIMIZE__ > 0 > +#define _FORTIFY_SOURCE 2 > +#endif]) Do we really need to put this in config.h? Wouldn't putting it straight in common/common-defs.h work out the same? We already define __STDC_CONSTANT_MACRO etc. there before any system header. Thanks, Pedro Alves