From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id AD3913858D34 for ; Wed, 15 Jul 2020 03:15:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD3913858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3038D1E111; Tue, 14 Jul 2020 23:15:39 -0400 (EDT) Subject: Re: [PATCH V5] Fix issues with reading rnglists, especially from dwo files, for DWARF v5 From: Simon Marchi To: Caroline Tice Cc: Eric Christopher , Tom Tromey , Caroline Tice via Gdb-patches References: <87h7vsqk5h.fsf@tromey.com> <87h7v815n7.fsf@tromey.com> <5eab18a1-c7e9-1a77-7f65-944eea10aa85@simark.ca> <5ccfe911-6049-e8f3-4874-9991b2649512@simark.ca> <4da310be-fa9f-9f21-8988-81af58ec73e3@simark.ca> Message-ID: Date: Tue, 14 Jul 2020 23:15:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4da310be-fa9f-9f21-8988-81af58ec73e3@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 03:15:41 -0000 On 2020-07-14 10:04 p.m., Simon Marchi wrote: > I don't think I have any more comments. Tom, are you ok with this? I just had a thought about the test, and testing in general of DWARF5 and split DWARF. Right now, it's not really testing DWARF5 range lists, as the name implies. It's more a general program that may happen to fail given the right compiler and compiler version. [In fact, could you mention (here and in the commit message) how to run your test case so that it fails, when the rest of your patch is not applied? The full "make check" command line, plus the compiler version used to compiler the test case. Ideally, we would have: - one test such for the very specific case you are fixing (DW_AT_ranges inside a dwo with DWARF5). We would use the DWARF assembler in lib/dwarf.exp to generate exactly what we want to test. It would probably need to be improved a bit to learn about rnglists though. - a new board file that tests with "-gsplit-dwarf -gdwarf5". A bit like fission.exp, but for DWARF5. I think a plain "-gdwarf5" board file would be useful too. Simon