From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11180 invoked by alias); 25 May 2018 18:06:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11171 invoked by uid 89); 25 May 2018 18:06:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 May 2018 18:06:35 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BECD37D83F; Fri, 25 May 2018 18:06:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 48A5D2026980; Fri, 25 May 2018 18:06:33 +0000 (UTC) Subject: Re: [RFA 3/4] Remove interp_ui_out To: Tom Tromey , gdb-patches@sourceware.org References: <20180430051207.19979-1-tom@tromey.com> <20180430051207.19979-4-tom@tromey.com> From: Pedro Alves Message-ID: Date: Fri, 25 May 2018 18:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180430051207.19979-4-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00693.txt.bz2 On 04/30/2018 06:12 AM, Tom Tromey wrote: > The function interp_ui_out simply calls the interp_ui_out method. > However, if it is passed a NULL interpreter, it first finds the > current interpreter. I believe, though, that NULL is never passed > here, and I think it's simpler to just remove this function and > require callers to be more explicit. OK. Thanks, Pedro Alves