* [PATCH] Remove stale comment
@ 2016-08-16 14:48 Simon Marchi
2016-08-17 13:57 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2016-08-16 14:48 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
This comment seems outdated, since exiting an inferior does not remove
it.
gdb/ChangeLog:
* inferior.c (exit_inferior_1): Remove comment.
---
gdb/inferior.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/gdb/inferior.c b/gdb/inferior.c
index df53f74..78b9c60 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -250,8 +250,6 @@ exit_inferior_1 (struct inferior *inftoex, int silent)
iterate_over_threads (delete_thread_of_inferior, &arg);
- /* Notify the observers before removing the inferior from the list,
- so that the observers have a chance to look it up. */
observer_notify_inferior_exit (inf);
inf->pid = 0;
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove stale comment
2016-08-16 14:48 [PATCH] Remove stale comment Simon Marchi
@ 2016-08-17 13:57 ` Pedro Alves
2016-08-17 14:28 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2016-08-17 13:57 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
On 08/16/2016 03:44 PM, Simon Marchi wrote:
> This comment seems outdated, since exiting an inferior does not remove
> it.
Right. And that observer used to take an int pid argument instead of
the inferior pointer directly.
>
> gdb/ChangeLog:
>
> * inferior.c (exit_inferior_1): Remove comment.
OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove stale comment
2016-08-17 13:57 ` Pedro Alves
@ 2016-08-17 14:28 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2016-08-17 14:28 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
On 16-08-17 09:57 AM, Pedro Alves wrote:
> On 08/16/2016 03:44 PM, Simon Marchi wrote:
>> This comment seems outdated, since exiting an inferior does not remove
>> it.
>
> Right. And that observer used to take an int pid argument instead of
> the inferior pointer directly.
>
>>
>> gdb/ChangeLog:
>>
>> * inferior.c (exit_inferior_1): Remove comment.
>
> OK.
Thanks, pushed!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-17 14:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16 14:48 [PATCH] Remove stale comment Simon Marchi
2016-08-17 13:57 ` Pedro Alves
2016-08-17 14:28 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).