From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/5] Random cleanup patches
Date: Fri, 9 Feb 2024 11:07:57 -0500 [thread overview]
Message-ID: <ae890af1-e61f-4753-939d-6deeb3fd46bf@simark.ca> (raw)
In-Reply-To: <87plx76mw2.fsf@redhat.com>
On 2024-02-08 09:39, Andrew Burgess wrote:
> Simon Marchi <simon.marchi@efficios.com> writes:
>
>> This is v2 of:
>>
>> https://inbox.sourceware.org/gdb-patches/20240206171514.119244-1-simon.marchi@efficios.com/T/#m396f40ecb617db9e71beae00f82f21bae92a36cd
>>
>> The only difference is to revert using the current inferior in patch 4,
>> as described here:
>>
>> https://inbox.sourceware.org/gdb-patches/20240206171514.119244-1-simon.marchi@efficios.com/T/#mb86bb48b17bdb01e5c0c28609aa168cb25722958
>
> So I didn't read V1 of this series prior to commenting on patch #4.
> Having been back to re-read the V1 series, and the problems that you ran
> into, I still think passing the current_inferior() would be a better
> choice in #4.
>
> For everything else:
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>
The comments on patch #4 were resolved, so I'll push that series now.
Thanks!
Simon
prev parent reply other threads:[~2024-02-09 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 16:53 Simon Marchi
2024-02-07 16:53 ` [PATCH v2 1/5] gdb: add program_space parameter to mark_breakpoints_out Simon Marchi
2024-02-07 16:53 ` [PATCH v2 2/5] gdb: add inferior parameter to breakpoint_init_inferior Simon Marchi
2024-02-07 16:53 ` [PATCH v2 3/5] gdb: add program_space parameter to disable_breakpoints_in_shlibs Simon Marchi
2024-02-07 16:53 ` [PATCH v2 4/5] gdb: add program_space parameter to clear_solib Simon Marchi
2024-02-08 14:29 ` Andrew Burgess
2024-02-08 16:21 ` Simon Marchi
2024-02-09 14:59 ` Andrew Burgess
2024-02-09 16:07 ` Simon Marchi
2024-02-07 16:53 ` [PATCH v2 5/5] gdb: remove unnecessary nullptr check in remove_user_added_objfile Simon Marchi
2024-02-08 14:39 ` [PATCH v2 0/5] Random cleanup patches Andrew Burgess
2024-02-09 16:07 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae890af1-e61f-4753-939d-6deeb3fd46bf@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).