From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by sourceware.org (Postfix) with ESMTPS id B74633857C50 for ; Thu, 31 Mar 2022 13:41:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B74633857C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f52.google.com with SMTP id h4so33877428wrc.13 for ; Thu, 31 Mar 2022 06:41:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=NcYtrb9aojGs2a52dJMaAA9yU+3nN36hYtdWDNLQMSs=; b=RKe6U9Q1dLWYRMANugRswVkRYXLFci2nFPz2sAMH5PaDpYy8AGGO2mWjECsnIQiaCg h4TiO6vveFAuYphsJyU2T+3u64ZSh2jB5sv6odliMTId8a7c6mGFz1tK23bViVCwR72I 3KCNH0ppLX+i+x2SHrnAPGejcrYAthzcf6+XbC+AifvU+G/BD49uo2d/5lEHdZHS/gS2 9MCmB0Cg+GJTLkRORc7v+EbYlPHR6cydMs1JS1Dy9hpqNUuiWt+AfXrSFIsMOJe+ew+j /aAO6LdGtd91j9mqKV+lidL71f8Za22XyxQTv6YggH/QdX6cw/MDA1W8afpXjL/eWWwa Y1Tg== X-Gm-Message-State: AOAM532WbXAen+ul8no3Xx8sUcwUqNRKo1txrbc71Eu1Z19pubGrSNnO 1ALzgmDEpnL0NgTA7mPBZhI= X-Google-Smtp-Source: ABdhPJwhNwWo7kF74Xba9dOHIRBgCoiQttzU3ZYyGROTd8Ta60bMTERFMiQWG5VOR3JX7alTeEW9Gg== X-Received: by 2002:adf:f9c9:0:b0:205:7ba0:121b with SMTP id w9-20020adff9c9000000b002057ba0121bmr4143727wrr.599.1648734070530; Thu, 31 Mar 2022 06:41:10 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id j15-20020a05600c1c0f00b0038cabc63721sm7780362wms.30.2022.03.31.06.41.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 06:41:09 -0700 (PDT) Message-ID: Date: Thu, 31 Mar 2022 14:41:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v7] gdb: Add new 'print nibbles' feature Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org References: From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 13:41:13 -0000 Hi! > +++ b/gdb/testsuite/gdb.cp/printnibbles.cc ... > diff --git a/gdb/testsuite/gdb.cp/printnibbles.exp b/gdb/testsuite/gdb.cp/printnibbles.exp ... > diff --git a/gdb/testsuite/gdb.rust/printnibbles.exp b/gdb/testsuite/gdb.rust/printnibbles.exp ... > diff --git a/gdb/testsuite/gdb.rust/printnibbles.rs b/gdb/testsuite/gdb.rust/printnibbles.rs ... I don't see why the testcases need to involve actual compiled programs? It could just do "print/t 1230" (etc) instead of "print/t var" ? With that, it would be possible to make the testcase iterate over all languages, doing "set language $lang", and printing nibbles for each language. gdb.base/nodebug.exp does something like that, for example. Pedro Alves