From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 6BD9039450FC
 for <gdb-patches@sourceware.org>; Wed, 11 Mar 2020 19:16:05 +0000 (GMT)
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id DAED71E481;
 Wed, 11 Mar 2020 15:16:04 -0400 (EDT)
Subject: Re: [PATCH] gdb: enable -Wmissing-prototypes warning
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
References: <20200303223442.330-1-simon.marchi@efficios.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <af09abf4-a94f-4342-e1a8-2711db80da53@simark.ca>
Date: Wed, 11 Mar 2020 15:16:03 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200303223442.330-1-simon.marchi@efficios.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, SPF_HELO_PASS,
 SPF_PASS autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2020 19:16:06 -0000

On 2020-03-03 5:34 p.m., Simon Marchi wrote:
> While compiling with clang, I noticed it didn't catch cases where my
> function declaration didn't match my function definition.  This is
> normally caught by gcc with -Wmissing-declarations.
> 
> On clang, this is caught by -Wmissing-prototypes instead.
> 
> Note that on gcc, -Wmissing-prototypes also exists, but is only valid
> for C and Objective-C.  It gets correctly rejected by the configure
> script since gcc rejects it with:
> 
>     cc1plus: error: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++ -Werror
> 
> So this warning flag ends up not used for gcc (which is what we want).
> 
> gdb/ChangeLog:
> 
> 	* configure: Re-generate.
> 
> gdbserver/ChangeLog:
> 
> 	* configure: Re-generate.
> 
> gdbsupport/ChangeLog:
> 
> 	* configure: Re-generate.
> 	* warning.m4: Enable -Wmissing-prototypes.

I just pushed this patch.

Simon