From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15112 invoked by alias); 13 Oct 2016 22:37:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15102 invoked by uid 89); 13 Oct 2016 22:37:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=much, much!, Hx-languages-length:1447, State X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 22:37:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6464683F47; Thu, 13 Oct 2016 22:37:27 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9DMbQoP013363; Thu, 13 Oct 2016 18:37:26 -0400 Subject: Re: [RFA v2 07/17] Remove make_cleanup_restore_current_ui To: Tom Tromey , gdb-patches@sourceware.org References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-8-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: Date: Thu, 13 Oct 2016 22:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476393012-29987-8-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00416.txt.bz2 On 10/13/2016 10:10 PM, Tom Tromey wrote: > --- a/gdb/top.h > +++ b/gdb/top.h > @@ -155,27 +155,48 @@ extern struct ui *current_ui; > /* The list of all UIs. */ > extern struct ui *ui_list; > > -/* State for SWITCH_THRU_ALL_UIS. Declared here because it is meant > - to be created on the stack, but should be treated as opaque. */ > -struct switch_thru_all_uis > +/* State for SWITCH_THRU_ALL_UIS. */ > +class switch_thru_all_uis > { > - struct ui *iter; > - struct cleanup *old_chain; > +public: > + > + switch_thru_all_uis () : m_iter (ui_list), m_save_ui (¤t_ui) > + { > + current_ui = ui_list; > + } > + > + // If done iterating, return true; otherwise return false. > + bool done () const > + { > + return m_iter == NULL; > + } > + > + // Move to the next UI, setting current_ui if iteration is not yet > + // complete. > + void next () > + { > + m_iter = m_iter->next; > + if (m_iter != NULL) > + current_ui = m_iter; > + } > + > + private: > + > + // No need for these. They are intentionally not defined anywhere. > + switch_thru_all_uis &operator= (const switch_thru_all_uis &); > + switch_thru_all_uis (const switch_thru_all_uis &); > + > + // Used to iterate through the UIs. > + struct ui *m_iter; > + > + // Save and restore current_ui. > + scoped_restore_tmpl m_save_ui; > }; // vs /**/ comments. OK with that change. Thanks much! Thanks, Pedro Alves