From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 26DC53858C78 for ; Mon, 23 Jan 2023 16:29:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26DC53858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4AA9F22760; Mon, 23 Jan 2023 16:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674491386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IrsIi/4oky7wVYLM8mvyixyw7CysdEVy0x8X9LbchtI=; b=TAsaCo6kWlwLhlLsIy0GqSYpuIFtHdkHCTIdUTllu9IZuyChtg7EAMhvHXlhIQquwQvbET lkDpQMu8TKG6R9yzFXrvJ0Q+xquPcttXZWotu8LVOsLbBAQ+iKhj1GOeQgtVvWpTj1TFpu 8nMBRY0bajA9Z+mCweUbInkOZg8P6gU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674491386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IrsIi/4oky7wVYLM8mvyixyw7CysdEVy0x8X9LbchtI=; b=Rwv67hNNsRn6x4/gen6BWMX6qBr1GRW6rQZYoB5iLsu72tLrfeydLyI9sOLMBwa2N8SzAL 8d0Bgjot70iOQ/Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 354B5134F5; Mon, 23 Jan 2023 16:29:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2i3dC/q1zmOGeAAAMHmgww (envelope-from ); Mon, 23 Jan 2023 16:29:46 +0000 Message-ID: Date: Mon, 23 Jan 2023 17:29:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [pushed] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230123075939.1771-1-tdevries@suse.de> <8cf44786-9ec3-8d14-24b7-41fdbb39b24f@simark.ca> From: Tom de Vries In-Reply-To: <8cf44786-9ec3-8d14-24b7-41fdbb39b24f@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/23/23 17:12, Simon Marchi wrote: > > > On 1/23/23 02:59, Tom de Vries via Gdb-patches wrote: >> When running test-case gdb.base/frame-view.exp, I see: >> ... >> gdb compile failed, ld: frame-view0.o: in function `main': >> frame-view.c:73: undefined reference to `pthread_create' >> ld: frame-view.c:76: undefined reference to `pthread_join' >> collect2: error: ld returned 1 exit status >> UNTESTED: gdb.base/frame-view.exp: failed to prepare >> ... >> >> Fix this by adding pthreads to the compilation flags. > > Thanks for fixing this. I suppose it worked on my machines because they > use newer glibcs where pthread is integrated into libc? Np, and ack, that's also what I suppose what happened. Thanks, - Tom