From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 92CF43858287 for ; Tue, 21 Nov 2023 17:25:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92CF43858287 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 92CF43858287 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700587511; cv=none; b=LQFD0A4kr/82H1jC8m/02lfFjTAUDHel8hkRsMB4vOFSpsNcjGKi9AQU/WEvJC9LnZTNfku0H74zuzLye5MfYnOV1RMYdXizI02xo/hU75zfBICAtM0B1gi1YhBTRK1q+4OsozhvBA2XuZdB65pQIbmhbPPWDNc/5HnHD7N5d6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700587511; c=relaxed/simple; bh=OW9zf7A4/0HkHPDpKFdEogHaGtIRb1BYIJSd87P85GA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GTopkxVtYvkwGoq60q8G4cKPNTALZe0s2zOimiiTAFWldUJQxg5qasIJUIIqEpjOhPnakla02qY5yjebLF+LiX2MUcp5IZMwrucWY02y8WDVZ4G5ga9bDACXJgTMDEtV5kjzOhenBHfN6kpGGdlM13140wOjPxxQr69ENBljzRE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700587509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IBx5x2JJK/qJW9viL3crg66d75XpeSCXi8mIwuVxiTQ=; b=M8+LsFozO2mgv8Bdujj+vVLfR0aKNJbzmJUHlbWk+mnbuteu3bqGqaidAg7GV2fF/lg8Oo QYRJOE7mlIEowcwWcKT6eMkTywtUdy+z6d3lyTAL7dSwOfgIP67v/vpI18hn/c5JI6N2/j zjNqnucwbdMgb43MDYVecr2bBwDi2sQ= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-YOJe_KzQMlGIbU7Zkohg4Q-1; Tue, 21 Nov 2023 12:25:08 -0500 X-MC-Unique: YOJe_KzQMlGIbU7Zkohg4Q-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-50aaa5d2a12so2848838e87.3 for ; Tue, 21 Nov 2023 09:25:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700587506; x=1701192306; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IBx5x2JJK/qJW9viL3crg66d75XpeSCXi8mIwuVxiTQ=; b=S4rRpYPIh+IxIlMAjWY7zfA3Pr9Tp0rJ8TSrEBOas7t4u8xWfZZVmo/MjOEW78NVcO x2grPCQ7Cbb2jxlGLQVoUxHL0kFV0E0awJXIIyF+9sVBwbHdkoxhS08YK+nD/2AEI5zU n0WwpSHpB9pQeKY9oC59a1xkUXCSFKXEj1+3djRsz7Zu1Ih36ef+5ua5ezmNKoWknrjZ /XmmubhnNugEjzcESN2oDVi9z+x0sX8DxxgpwVFtG/qszC44RhJ/1da69fYeywOXcZRa wHBsC8+S35VpnHUH5F69LDO8fng3mgeL5P4JhDCEYWoX8KjMSi8x/2ap+ePx9k+4GeBV RnDw== X-Gm-Message-State: AOJu0YxdePW+J8gulwvZdO6tP6jMwElHxD8NpySLQIifd+v3jIho1xop l8rLLYLgO1D/Rqp2xUt5+75txaN5ML8MtFoV+Bx5VbOjwLEjVcyXEY2jBfdT6Bq5pq4duvoySlW LHM01lrRP5HUS8xUMjJ2PSg== X-Received: by 2002:a19:5f0e:0:b0:500:8022:3dc7 with SMTP id t14-20020a195f0e000000b0050080223dc7mr7454938lfb.10.1700587506378; Tue, 21 Nov 2023 09:25:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmBTt14zroKcGf/C8fsZm28jprhjV5fNHZCU1bR+NTNNq8IbqA4t2fdTvP5eJzGtAS8pz0rg== X-Received: by 2002:a19:5f0e:0:b0:500:8022:3dc7 with SMTP id t14-20020a195f0e000000b0050080223dc7mr7454921lfb.10.1700587506007; Tue, 21 Nov 2023 09:25:06 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id b8-20020aa7dc08000000b00543597cd190sm5063272edu.47.2023.11.21.09.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Nov 2023 09:25:05 -0800 (PST) Message-ID: Date: Tue, 21 Nov 2023 18:25:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PING][PATCH v6] [gdb]: add git trailer information on gdb/MAINTAINERS To: Guinevere Larsen , Gdb-patches References: <20231102135457.3663735-2-blarsen@redhat.com> From: Guinevere Larsen In-Reply-To: <20231102135457.3663735-2-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping! -- Cheers, Guinevere Larsen She/Her/Hers On 02/11/2023 14:54, Guinevere Larsen wrote: > The project has been using Tested-By (tb), Reviewed-By (rb) and > Approved-By (ab) for some time, but there has been no information to be > found in the actual repository. This commit changes that by adding > information about all git trailers to the MAINTAINERS file, so that it > can be easily double-checked. Simply put, the trailers in use work as > follows: > > * Tested-by: The person tested the patch and it fixes the problem, or > introduces no regressions (or both). > * Acked-by: The general outline looks good, but the maintainer hasn't > looked at the code > * Reviewed-by: The code looks good, but the reviewer has not approved > the patch to go upstream > * Approved-by: The patch is ready to be pushed to master > > These last 3 trailers can also be restricted to one or more areas of GDB > by adding the areas in a comma separated list in parenthesis after the > trailers. > > Finally, for completeness sake, the trailers Co-Authored-By and Bug > were added, even though they have been in use for a long time already > > --- > gdb/MAINTAINERS | 93 ++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 85 insertions(+), 8 deletions(-) > > diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS > index 9989956065e..e1bb437a675 100644 > --- a/gdb/MAINTAINERS > +++ b/gdb/MAINTAINERS > @@ -43,14 +43,9 @@ patch without review from another maintainer. This especially includes > patches which change internal interfaces (e.g. global functions, data > structures) or external interfaces (e.g. user, remote, MI, et cetera). > > -The term "review" is used in this file to describe several kinds of feedback > -from a maintainer: approval, rejection, and requests for changes or > -clarification with the intention of approving a revised version. Review is > -a privilege and/or responsibility of various positions among the GDB > -Maintainers. Of course, anyone - whether they hold a position but not the > -relevant one for a particular patch, or are just following along on the > -mailing lists for fun, or anything in between - may suggest changes or > -ask questions about a patch! > +The word "contributor" is used in this document to refer to any GDB > +developer listed above as well as folks who may have suggested some > +patches but aren't part of one of those categories for any reason. > > There's also a couple of other people who play special roles in the GDB > community, separately from the patch process: > @@ -78,6 +73,88 @@ consensus among the global maintainers and any other involved parties. > In cases where consensus can not be reached, the global maintainers may > ask the official FSF-appointed GDB maintainers for a final decision. > > +The term "review" is used in this file to describe several kinds of > +feedback from a maintainer: approval, rejection, and requests for changes > +or clarification with the intention of approving a revised version. > +Approval is a privilege and/or responsibility of various positions among > +the GDB Maintainers. Of course, anyone - whether they hold a position, but > +not the relevant one for a particular patch, or are just following along on > +the mailing lists for fun, or anything in between - may suggest changes, ask > +questions about a patch or say if they believe a patch is fit for upstreaming! > + > +To ensure that patches are only pushed when approved, and to properly credit > +the contributors who take the time to improve this project, the following > +trailers are used to identify who contributed and how. All patches pushed > +upstream should have at least one Approved-By trailers (with the exception of > +obvious patches, see below). The trailers (or tags) currently in use are: > + > + - Tested-by: > + > + Used when a contributor has tested the patch and finds that it > + fixes the claimed problem. It may also be used to indicate that > + the contributor has performed regression testing. By itself, this > + tag says nothing about the quality of the fix implemented by the > + patch, nor the amount of testing that was actually performed. > + Usage: "Tested-By: Your Name " > + > + - Acked-By: > + > + Used when a responsible or global maintaner has taken a superficial > + look at a patch and agree with its direction, but has not done further > + review on the subject. > + This trailer can be specific to one or more areas of the project, as > + defined by the "Responsible maintainers" section of this file. If > + that is the case, the area(s) should be added at the end of the tag in > + parenthesis in a comma separated list. > + Usage: "Acked-By: Your Name (area1, area2)" > + > + - Reviewed-by: > + > + Used when a contributor has looked at the code and agrees with > + the changes, but either doesn't have the authority or doesn't > + feel comfortable approving the patch. > + This trailer can be specific to one or more areas of the project, as > + defined by the "Responsible maintainers" section of this file. If > + that is the case, the area(s) should be added at the end of the tag in > + parenthesis in a comma separated list. > + Usage: "Reviewed-By: Your Name (area1, area2)" > + > + - Approved-by: > + > + Used by responsible maintainers or global maintainers when a patch is > + ready to be upstreamed. If a patch requires multiple approvals, only > + the last reviewer should use this tag, making it obvious to the > + contributor that the patch is ready to be pushed. > + This trailer can be specific to one or more areas of the project, as > + defined by the "Responsible maintainers" section of this file. If > + that is the case, the area(s) should be added at the end of the tag in > + parenthesis in a comma separated list. Patches must have all areas > + approved before being pushed. If a patch has had some areas approved, > + it is recommended that the final approver makes it explicit that the > + patch is ready for pushing. > + Responsible, Global and Official FSF-appointed maintainers may approve > + their own patches, but it is recommended that they seek external approval > + before doing so. > + Usage: "Approved-By: Your Name " > + > + - Co-Authored-By: > + > + Used when the commit includes meaningful conrtibutions from multiple people. > + Usage: "Co-Authored-By: Contributor's Name " > + > + - Bug: > + > + This trailer is added with a link to the GDB bug tracker bug for > + added context on relevant commits. > + Usage: "Bug: " > + > +Sometimes, contributors may request small changes, such as fixing typos, before > +granting the review or approval trailer. When the contributor thinks that > +these changes are so small that it isn't necessary to send a new version, they > +may add some text like "with these changes, I'm ok with the patch", followed by > +their trailer. In those situations, the trailer is only valid after the > +changes are made. > + > > The Obvious Fix Rule > --------------------