From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72056 invoked by alias); 12 Jul 2017 12:16:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70348 invoked by uid 89); 12 Jul 2017 12:16:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=phil, H*Ad:U*pmuldoon X-HELO: mail-wr0-f171.google.com Received: from mail-wr0-f171.google.com (HELO mail-wr0-f171.google.com) (209.85.128.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Jul 2017 12:16:44 +0000 Received: by mail-wr0-f171.google.com with SMTP id 77so31340802wrb.1 for ; Wed, 12 Jul 2017 05:16:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a0ZnT21dC8SOJluAcpDAsILmHPnPdXtEpoqxUwYvKZQ=; b=tBSDmHMTVeYVgHg5V8NbDQF9/oon8WlCKV/+buMG5yKgjHs5QinYGgzM4b+9ttmYde msRT0P+gTr1ke/rZ1sng7PSZXfH4EEC37mPAVeZSio3/AA/yVflEGpQ52/be6olefFXK +0pNLdAj1emeTsd84ZH1TJ2F8M6BYKtlgwBsOW6PWyw50E/9HofXLdXLGHI0QM94smbk ILUEpWjMpr2ugk5F6lewnP8qlaDes3mim5URMjtV1cGC+3LL3tJDsLwSP9qreU6oro11 M+t2fr/WWqvyur28UWDF3bTG3w0UkoN7aqJU0tCyEtEYbbf75RgDBVquXYeL6sr3reIz 6kIQ== X-Gm-Message-State: AIVw113fTQiiKCiXtfzhyFQ3HavUBaWTh3lBzhlS7jxFKsiE/XPOaFYn n7FTWQE+WG61sXGRzGpypQ== X-Received: by 10.28.178.69 with SMTP id b66mr2214641wmf.99.1499861802282; Wed, 12 Jul 2017 05:16:42 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id i67sm1712109wri.61.2017.07.12.05.16.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jul 2017 05:16:41 -0700 (PDT) Subject: Re: [PATCH 1/2] Include the fs_base and gs_base registers in amd64 target descriptions. To: Yao Qi , John Baldwin Cc: gdb-patches@sourceware.org References: <20170627224948.99138-1-jhb@FreeBSD.org> <20170627224948.99138-2-jhb@FreeBSD.org> <86shi3qu5m.fsf@gmail.com> From: Phil Muldoon Message-ID: Date: Wed, 12 Jul 2017 12:16:00 -0000 MIME-Version: 1.0 In-Reply-To: <86shi3qu5m.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00104.txt.bz2 On 11/07/17 09:01, Yao Qi wrote: > John Baldwin writes: > >> This permits these registers to be used with non-Linux targets. > > Some GDBserver uses these target description files, like > x86_64-*-mingw*, after this change, GDBserver will reply GDB the target > description including "64bit-segments.xml". Then, GDB will request the > contents of 64bit-segments.xml from GDBserver, looks 64bit-segments.xml > is already builtin in GDBserver, so there isn't an issue here. > > The patch is good to me. > > P.S. this is a good example to show the inflexibility in current target > description. After we change it to my new approach of target > description, this change will be just two or three lines :) > This commit: 48aeef91c248291dd03583798904612426b1f40a along with related commit: 0aa37b654c0f31e446ab47826f0bcbec15d0112f seems to cause substantial testsuite failures for me on x8664/Fedora/Linux. Backtrace of a trivial: file helloworld (gdb) bt #0 0x0000000000937b51 in htab_remove_elt_with_hash (htab=0x133f5d0, element=0xf0a180, hash=2401929989) at ../../binutils-gdb/libiberty/hashtab.c:728 #1 0x0000000000937b1b in htab_remove_elt (htab=0x133f5d0, element=0xf0a180) at ../../binutils-gdb/libiberty/hashtab.c:714 #2 0x00000000007b7c02 in tdesc_use_registers (gdbarch=0x1346ac0, target_desc=0xf2f540, early_data=0x133f5a0) at ../../binutils-gdb/gdb/target-descriptions.c:1328 #3 0x000000000045079c in i386_gdbarch_init (info=..., arches=0x0) at ../../binutils-gdb/gdb/i386-tdep.c:8634 #4 0x00000000006be323 in gdbarch_find_by_info (info=...) at ../../binutils-gdb/gdb/gdbarch.c:5394 #5 0x00000000005bddd9 in set_gdbarch_from_file (abfd=0x133d1d0) at ../../binutils-gdb/gdb/arch-utils.c:618 #6 0x000000000069777d in exec_file_attach (filename=0x13301d0 "/home/pmuldoon/td", from_tty=1) at ../../binutils-gdb/gdb/exec.c:380 Does anyone else see this? Cheers Phil