From: Luis Machado <luis.machado@linaro.org>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] gdb: change print format of flag enums with value 0
Date: Mon, 17 Feb 2020 12:08:00 -0000 [thread overview]
Message-ID: <af92da13-6dc5-e02c-3469-84bbccdcfd80@linaro.org> (raw)
In-Reply-To: <20200213203035.30157-5-simon.marchi@efficios.com>
On 2/13/20 5:30 PM, Simon Marchi wrote:
> If a flag enum has value 0 and the enumeration type does not have an
> enumerator with value 0, we currently print:
>
> $1 = (unknown: 0x0)
>
> I don't like the display of "unknown" here, since for flags, 0 is a
> an expected value. It just means that no flags are set. This patch
> makes it so that we print it as a simple 0 in this situation:
Should we print "no flags set" alongside the 0 for this case then?
>
> $1 = 0
>
> If there is an enumerator with value 0, it is still printed using that
> enumerator, for example (from the test):
>
> $1 = FE_NONE
>
> gdb/ChangeLog:
>
> * valprint.c (generic_val_print_enum_1): When printing a flag
> enum with value 0 and there is no enumerator with value 0, print
> just "0" instead of "(unknown: 0x0)".
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/printcmds.exp (test_print_enums): Update expected
> output.
> ---
> gdb/testsuite/gdb.base/printcmds.exp | 2 +-
> gdb/valprint.c | 31 +++++++++++++++++++++-------
> 2 files changed, 25 insertions(+), 8 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp
> index d6f5c75650bf..bd2afc8696f0 100644
> --- a/gdb/testsuite/gdb.base/printcmds.exp
> +++ b/gdb/testsuite/gdb.base/printcmds.exp
> @@ -743,7 +743,7 @@ proc test_print_enums {} {
> gdb_test "print (enum flag_enum) 0x0" [string_to_regexp " = FE_NONE"]
>
> # Print a flag enum with value 0, where no enumerator has value 0.
> - gdb_test "print flag_enum_without_zero" [string_to_regexp " = (unknown: 0x0)"]
> + gdb_test "print flag_enum_without_zero" [string_to_regexp " = 0"]
>
> # Print a flag enum with unknown bits set.
> gdb_test "print (enum flag_enum) 0xf1" [string_to_regexp " = (FE_ONE | unknown: 0xf0)"]
> diff --git a/gdb/valprint.c b/gdb/valprint.c
> index bd21be69e1bf..6e62d420c0f4 100644
> --- a/gdb/valprint.c
> +++ b/gdb/valprint.c
> @@ -634,7 +634,6 @@ generic_val_print_enum_1 (struct type *type, LONGEST val,
> /* We have a "flag" enum, so we try to decompose it into
> pieces as appropriate. A flag enum has disjoint
> constants by definition. */
> - fputs_filtered ("(", stream);
> for (i = 0; i < len; ++i)
> {
> QUIT;
> @@ -646,24 +645,42 @@ generic_val_print_enum_1 (struct type *type, LONGEST val,
>
> if ((val & enumval) != 0)
> {
> - if (!first)
> + if (first)
> + {
> + fputs_filtered ("(", stream);
> + first = 0;
> + }
> + else
> fputs_filtered (" | ", stream);
> - first = 0;
>
> val &= ~TYPE_FIELD_ENUMVAL (type, i);
> fputs_filtered (TYPE_FIELD_NAME (type, i), stream);
> }
> }
>
> - if (first || val != 0)
> + if (val != 0)
> {
> - if (!first)
> + /* There are leftover bits, print them. */
> + if (first)
> + fputs_filtered ("(", stream);
> + else
> fputs_filtered (" | ", stream);
> +
> fputs_filtered ("unknown: 0x", stream);
> print_longest (stream, 'x', 0, val);
> + fputs_filtered (")", stream);
> + }
> + else if (first)
> + {
> + /* Nothing has been printed and the value is 0, the enum value must
> + have been 0. */
> + fputs_filtered ("0", stream);
> + }
> + else
> + {
> + /* Something has been printed, close the parenthesis. */
> + fputs_filtered (")", stream);
> }
> -
> - fputs_filtered (")", stream);
> }
> else
> print_longest (stream, 'd', 0, val);
>
Otherwise LGTM.
next prev parent reply other threads:[~2020-02-17 12:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:30 [PATCH 1/5] gnulib: import count-one-bits module and use it Simon Marchi
2020-02-13 20:30 ` [PATCH 3/5] gdb: allow duplicate enumerators in flag enums Simon Marchi
2020-02-17 11:01 ` Luis Machado
2020-02-18 20:38 ` Tom Tromey
2020-02-18 20:42 ` Tom Tromey
2020-02-18 20:48 ` Simon Marchi
2020-02-18 21:57 ` Tom Tromey
2020-02-18 22:25 ` Simon Marchi
2020-02-13 20:30 ` [PATCH 2/5] gdb: fix printing of flag enums with multi-bit enumerators Simon Marchi
2020-02-17 10:56 ` Luis Machado
2020-02-17 17:27 ` Simon Marchi
2020-02-17 17:40 ` Luis Machado
2020-02-17 19:20 ` Simon Marchi
2020-02-18 20:42 ` Tom Tromey
2020-02-13 20:30 ` [PATCH 5/5] gdb: change print format of flag enums with value 0 Simon Marchi
2020-02-17 12:08 ` Luis Machado [this message]
2020-02-17 19:02 ` Simon Marchi
2020-02-18 20:45 ` Tom Tromey
2020-02-18 20:52 ` Simon Marchi
2020-02-13 20:38 ` [PATCH 4/5] gdb: print unknown part of flag enum in hex Simon Marchi
2020-02-17 11:04 ` Luis Machado
2020-02-17 18:59 ` Simon Marchi
2020-02-18 20:43 ` Tom Tromey
2020-02-14 19:53 ` [PATCH 1/5] gnulib: import count-one-bits module and use it Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af92da13-6dc5-e02c-3469-84bbccdcfd80@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).