From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 5F3083858D28 for ; Mon, 28 Aug 2023 17:32:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F3083858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RZHgK6Qmdz4QjY; Mon, 28 Aug 2023 17:32:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RZHgK5bRNz3Pyt; Mon, 28 Aug 2023 17:32:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693243933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3NMdJqGEZVWFWR77BK2jxYTOqkAXAEuZvU2d3bLTnhc=; b=QYl6Uvalf9oIDmzUGmvhcS/SoMxd1a+3i4o5gzzKpicKdYk0BC+xMV+/MAPNqu+Dd0w7Rl QFoQK71mPPzJXlWqPHtewb3rSDW0RiINWPbkFVZZZEOmLjBiSlUN6snj6RYekJTCMT6SzM eifPNVERR5LUYoFYz7ZFfocJejkB2PYJ3t5IbXiYZfHeFsPiD0oaV1GyLFWZ3+tvLwoHUe btkzL0+j3ifML+taVgV4ms3ISbCl8hCZtszbRgROWZglAOwnmnSD5urVVOXqvZ1CAUId50 EoRrun04y7cd95JEuXXJcuShDcYjE70/ScHXhD8OekG4GcD5bcOmMySkO3ZkSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693243933; a=rsa-sha256; cv=none; b=ijdQ9sE9nz3RH7mJy2RLxxB6rasTtvfkCB6zKW2qf36YpiNppSm88JPoJ/IFl0GCa2ZXO2 zyjb4XtMHBYfMj4YVVCg/AtKUBI7I+kV+dpEcSnwevvC+0SkNtsAq6mxWfXJsyLCKJIa6w +Q0OJbG9cXVenBuqPjaEx4sHZ0OOV2RBfy4ERL4cYWsJexQDzaLtZAGAghL/JSnVa6HCL8 htZg8XNumtqsPmXqXAk5Y5aUrogEta2BI/imfjybK51KkpD63gxEUI8ZZ5CTyGzHf0rbl/ AneCbtyM+Y7Mzi+ZFfBi5+iXTHhFWA5/tXsyVZ0XD5JvTCST2K2726+Ang9c+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693243933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3NMdJqGEZVWFWR77BK2jxYTOqkAXAEuZvU2d3bLTnhc=; b=ApCQitsEIemXXFUpr4hDvKN6Y/NexSnzi18BtqFjXI0KeiuqKOeIuTLEhg9qLe74p7EC1T sw4qzl5FPIt1GYCLg3neKLWZNEfhnHsUVi1yqYOFQmft55Y8Oq+5hc8MSQf0cpzzkc+/t9 sytlNXEbyEl0/nHXEhK4e94RNRzUoMya5jaKVqZXxjwYD2xVXEc8TZrMyonIal9rykrnMD RttPRKp1isMS+X+tOVChpiWYNxkjgGaTCf8i7Y2+u9z4C5L92dSNf/2KEkWg7iP9T8m3v3 IwBHwH+wyWHss+/StFXO8p4TTzUNKmSroyEhRBpEhTxd5HJOrkiW/bXubIKqcA== Received: from [IPV6:2601:648:8683:a9e0:3858:44e8:8d12:eaf0] (unknown [IPv6:2601:648:8683:a9e0:3858:44e8:8d12:eaf0]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RZHgK2JzQzB76; Mon, 28 Aug 2023 17:32:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 28 Aug 2023 10:32:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v6 12/15] gdbserver: Refactor the legacy region within the xsave struct Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: Aleksandar Paunovic References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-13-jhb@FreeBSD.org> <00691d7c-e771-4469-a0be-681c7c30a4e1@polymtl.ca> From: John Baldwin In-Reply-To: <00691d7c-e771-4469-a0be-681c7c30a4e1@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/28/23 9:50 AM, Simon Marchi wrote: > On 7/14/23 11:51, John Baldwin wrote: >> From: Aleksandar Paunovic >> >> Legacy fields of the XSAVE area are already defined within fx_save >> struct. Use class inheritance to remove code duplication. >> >> The two changed functions are called within all tests which run >> gdbserver. >> >> Signed-off-by: Aleksandar Paunovic >> Co-authored-by: John Baldwin >> --- >> gdbserver/i387-fp.cc | 27 ++------------------------- >> 1 file changed, 2 insertions(+), 25 deletions(-) >> >> diff --git a/gdbserver/i387-fp.cc b/gdbserver/i387-fp.cc >> index b8d7a912f26..a122e2d860b 100644 >> --- a/gdbserver/i387-fp.cc >> +++ b/gdbserver/i387-fp.cc >> @@ -81,29 +81,7 @@ struct i387_fxsave { >> unsigned char xmm_space[256]; >> }; >> >> -struct i387_xsave { >> - /* All these are only sixteen bits, plus padding, except for fop (which >> - is only eleven bits), and fooff / fioff (which are 32 bits each). */ >> - unsigned short fctrl; >> - unsigned short fstat; >> - unsigned short ftag; >> - unsigned short fop; >> - unsigned int fioff; >> - unsigned short fiseg; >> - unsigned short pad1; >> - unsigned int fooff; >> - unsigned short foseg; >> - unsigned short pad12; >> - >> - unsigned int mxcsr; >> - unsigned int mxcsr_mask; >> - >> - /* Space for eight 80-bit FP values in 128-bit spaces. */ >> - unsigned char st_space[128]; >> - >> - /* Space for eight 128-bit XMM values, or 16 on x86-64. */ >> - unsigned char xmm_space[256]; >> - >> +struct i387_xsave : public i387_fxsave { > > > The { should go on the next line... can you fix all the structs in this > file with an obvious patch on top of the series? Will do, thanks! -- John Baldwin