* [PATCH] gdb: use dynamic year in update-freebsd.sh
@ 2023-02-01 13:31 Enze Li
2023-02-01 19:44 ` John Baldwin
2023-03-28 13:40 ` [PING][PATCH] " Enze Li
0 siblings, 2 replies; 5+ messages in thread
From: Enze Li @ 2023-02-01 13:31 UTC (permalink / raw)
To: gdb-patches; +Cc: enze.li, jhb
When running update-freebsd.sh on FreeBSD, I see the following
modification in freebsd.xml,
-<!-- Copyright (C) 2009-2023 Free Software Foundation, Inc.
+<!-- Copyright (C) 2009-2020 Free Software Foundation, Inc.
It means that each time, when we running the update-freebsd.sh on
FreeBSD, we have to correct the year of copyright manually. So fix this
issue by using dynamic year.
Tested by regenerating freebsd.xml on FreeBSD/amd64.
---
gdb/syscalls/update-freebsd.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gdb/syscalls/update-freebsd.sh b/gdb/syscalls/update-freebsd.sh
index b5b882e921b..ce82564e5c0 100755
--- a/gdb/syscalls/update-freebsd.sh
+++ b/gdb/syscalls/update-freebsd.sh
@@ -33,10 +33,12 @@ if [ $# -ne 1 ]; then
exit 1
fi
+year=$(date +%Y)
+
cat > freebsd.xml.tmp <<EOF
<?xml version="1.0"?> <!-- THIS FILE IS GENERATED -*- buffer-read-only: t -*- -->
<!-- vi:set ro: -->
-<!-- Copyright (C) 2009-2020 Free Software Foundation, Inc.
+<!-- Copyright (C) 2009-$year Free Software Foundation, Inc.
Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
base-commit: 4788abdec79a937e51ad334b608fa1bd03713112
--
2.39.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] gdb: use dynamic year in update-freebsd.sh
2023-02-01 13:31 [PATCH] gdb: use dynamic year in update-freebsd.sh Enze Li
@ 2023-02-01 19:44 ` John Baldwin
2023-03-28 13:40 ` [PING][PATCH] " Enze Li
1 sibling, 0 replies; 5+ messages in thread
From: John Baldwin @ 2023-02-01 19:44 UTC (permalink / raw)
To: Enze Li, gdb-patches; +Cc: enze.li
On 2/1/23 5:31 AM, Enze Li wrote:
> When running update-freebsd.sh on FreeBSD, I see the following
> modification in freebsd.xml,
>
> -<!-- Copyright (C) 2009-2023 Free Software Foundation, Inc.
> +<!-- Copyright (C) 2009-2020 Free Software Foundation, Inc.
>
> It means that each time, when we running the update-freebsd.sh on
> FreeBSD, we have to correct the year of copyright manually. So fix this
> issue by using dynamic year.
>
> Tested by regenerating freebsd.xml on FreeBSD/amd64.
LGTM.
Reviewed-by: John Baldwin <jhb@FreeBSD.org>
--
John Baldwin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING][PATCH] gdb: use dynamic year in update-freebsd.sh
2023-02-01 13:31 [PATCH] gdb: use dynamic year in update-freebsd.sh Enze Li
2023-02-01 19:44 ` John Baldwin
@ 2023-03-28 13:40 ` Enze Li
2023-03-28 13:50 ` Simon Marchi
1 sibling, 1 reply; 5+ messages in thread
From: Enze Li @ 2023-03-28 13:40 UTC (permalink / raw)
To: gdb-patches; +Cc: enze.li, jhb
Hi all,
Kindly PING for this patch. John has reviewed the patch, but still
needs a global maintainer to take a look at it.
Best Regards,
Enze
On Wed, 2023-02-01 at 21:31 +0800, Enze Li via Gdb-patches wrote:
> When running update-freebsd.sh on FreeBSD, I see the following
> modification in freebsd.xml,
>
> -<!-- Copyright (C) 2009-2023 Free Software Foundation, Inc.
> +<!-- Copyright (C) 2009-2020 Free Software Foundation, Inc.
>
> It means that each time, when we running the update-freebsd.sh on
> FreeBSD, we have to correct the year of copyright manually. So fix
> this
> issue by using dynamic year.
>
> Tested by regenerating freebsd.xml on FreeBSD/amd64.
> ---
> gdb/syscalls/update-freebsd.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/syscalls/update-freebsd.sh b/gdb/syscalls/update-
> freebsd.sh
> index b5b882e921b..ce82564e5c0 100755
> --- a/gdb/syscalls/update-freebsd.sh
> +++ b/gdb/syscalls/update-freebsd.sh
> @@ -33,10 +33,12 @@ if [ $# -ne 1 ]; then
> exit 1
> fi
>
> +year=$(date +%Y)
> +
> cat > freebsd.xml.tmp <<EOF
> <?xml version="1.0"?> <!-- THIS FILE IS GENERATED -*- buffer-read-
> only: t -*- -->
> <!-- vi:set ro: -->
> -<!-- Copyright (C) 2009-2020 Free Software Foundation, Inc.
> +<!-- Copyright (C) 2009-$year Free Software Foundation, Inc.
>
> Copying and distribution of this file, with or without
> modification,
> are permitted in any medium without royalty provided the
> copyright
>
> base-commit: 4788abdec79a937e51ad334b608fa1bd03713112
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING][PATCH] gdb: use dynamic year in update-freebsd.sh
2023-03-28 13:40 ` [PING][PATCH] " Enze Li
@ 2023-03-28 13:50 ` Simon Marchi
2023-03-28 14:10 ` Enze Li
0 siblings, 1 reply; 5+ messages in thread
From: Simon Marchi @ 2023-03-28 13:50 UTC (permalink / raw)
To: Enze Li, gdb-patches; +Cc: enze.li, jhb
On 3/28/23 09:40, Enze Li via Gdb-patches wrote:
> Hi all,
>
> Kindly PING for this patch. John has reviewed the patch, but still
> needs a global maintainer to take a look at it.
>
> Best Regards,
> Enze
I think that John could have given you an Approved-By. But in any case:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING][PATCH] gdb: use dynamic year in update-freebsd.sh
2023-03-28 13:50 ` Simon Marchi
@ 2023-03-28 14:10 ` Enze Li
0 siblings, 0 replies; 5+ messages in thread
From: Enze Li @ 2023-03-28 14:10 UTC (permalink / raw)
To: Simon Marchi, gdb-patches; +Cc: enze.li, jhb
Hi Simon, John,
Thanks for the review. I'm checking this in now.
Enze
On Tue, 2023-03-28 at 09:50 -0400, Simon Marchi wrote:
> On 3/28/23 09:40, Enze Li via Gdb-patches wrote:
> > Hi all,
> >
> > Kindly PING for this patch. John has reviewed the patch, but still
> > needs a global maintainer to take a look at it.
> >
> > Best Regards,
> > Enze
>
> I think that John could have given you an Approved-By. But in any
> case:
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> Simon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-28 14:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-01 13:31 [PATCH] gdb: use dynamic year in update-freebsd.sh Enze Li
2023-02-01 19:44 ` John Baldwin
2023-03-28 13:40 ` [PING][PATCH] " Enze Li
2023-03-28 13:50 ` Simon Marchi
2023-03-28 14:10 ` Enze Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).