From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106857-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18311 invoked by alias); 1 Nov 2013 23:40:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18289 invoked by uid 89); 1 Nov 2013 23:40:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Nov 2013 23:40:31 +0000
Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93])	by relay1.mentorg.com with esmtp 	id 1VcOKJ-0000iL-65 from Maciej_Rozycki@mentor.com ; Fri, 01 Nov 2013 16:40:27 -0700
Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Fri, 1 Nov 2013 16:40:27 -0700
Received: from [172.30.64.29] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Fri, 1 Nov 2013 23:40:25 +0000
Date: Fri, 01 Nov 2013 23:40:00 -0000
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb.dwarf2/dwzbuildid.exp: Avoid reserved variable name
In-Reply-To: <87fvrgyvyw.fsf@fleche.redhat.com>
Message-ID: <alpine.DEB.1.10.1311012337410.12843@tp.orcam.me.uk>
References: <alpine.DEB.1.10.1311010024370.12843@tp.orcam.me.uk> <87fvrgyvyw.fsf@fleche.redhat.com>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-SW-Source: 2013-11/txt/msg00024.txt.bz2

On Fri, 1 Nov 2013, Tom Tromey wrote:

> Maciej> 	gdb/testsuite/
> Maciej> 	* gdb.dwarf2/dwzbuildid.exp: Rename `outdir' variable to 
> Maciej> 	`debugdir'.
> 
> Ok.

 Thanks for your review, I have applied the change now.

> I wonder whether we should mention it in banned_variables.

 Hmm, would it make sense to grep lib/*.exp for global variable references 
and see if there are any other candidates?

  Maciej