From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Tom Tromey <tromey@redhat.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] GDB/testsuite: Bump up `match_max'
Date: Tue, 20 May 2014 00:47:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1405200137590.12061@tp.orcam.me.uk> (raw)
In-Reply-To: <CADPb22SVw2kVVMrTVXTQWN1chb4V-+N_=TXHq7J30Sx5B8FY_w@mail.gmail.com>
On Mon, 19 May 2014, Doug Evans wrote:
> >> > I wonder whether you timed the test suite?
> >> > The expect man page says:
> >> >
> >> > This may be changed with the function match_max. (Note that excessively
> >> > large values can slow down the pattern matcher.)
> >> >
> >> > If it is notably slower then it would be better to rewrite the macro
> >> > tests to avoid this need.
> >>
> >> Funny you would say that! I was reviewing the patch, and decided to
> >> do exactly that. Ran into trouble (fresh install), but almost there...
> >
> > Here are the results. As I hoped, it doesn't seem to introduce
> > any noticeable difference (at -j16 on an 8-thread machine).
> >
> > Before: 1093.79s user 153.20s system 589% cpu 3:31.68 total
> > After: 1097.58s user 155.08s system 589% cpu 3:32.39 total
>
> fwiw, I did several runs of before/after with the testsuite running
> serially and didn't find any statistical difference.
> All runs were in the range 14:07s to 14:25s elapsed, and sometimes
> with-patch was faster.
> Not unexpected I guess - most of the time what's actually in the
> buffer is pretty small, much less than the buffer size, so other
> factors would (generally) have more of an influence on run time.
Have we reached consensus? At this point of discussion I don't have
anything to add -- all has been already written AFAICT. Thank you all for
verifying the change.
Maciej
next prev parent reply other threads:[~2014-05-20 0:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 20:57 Maciej W. Rozycki
2014-05-19 14:18 ` Tom Tromey
2014-05-19 14:23 ` Joel Brobecker
2014-05-19 14:37 ` Joel Brobecker
2014-05-19 21:22 ` Doug Evans
2014-05-20 0:47 ` Maciej W. Rozycki [this message]
2014-05-20 2:05 ` Joel Brobecker
2014-05-21 19:41 ` Maciej W. Rozycki
2023-10-03 19:53 [PATCH] gdb/testsuite: Bump up 'match_max' Thiago Jung Bauermann
2023-10-04 1:04 ` Simon Marchi
2023-10-04 22:43 ` Thiago Jung Bauermann
2023-10-05 1:39 ` Simon Marchi
2023-10-05 2:41 ` Thiago Jung Bauermann
2023-10-06 17:01 ` Andrew Burgess
2023-10-06 20:34 ` Thiago Jung Bauermann
2023-10-09 9:49 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1405200137590.12061@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).