public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
	<gdb-patches@sourceware.org>
Subject: [PING][PATCH] GDB/testsuite: Add a way to send multiple init commands
Date: Thu, 19 Jun 2014 23:39:00 -0000	[thread overview]
Message-ID: <alpine.DEB.1.10.1406200028100.3924@tp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.1406111821290.3047@tp.orcam.me.uk>

On Wed, 11 Jun 2014, Maciej W. Rozycki wrote:

> On Wed, 11 Jun 2014, Tom Tromey wrote:
> 
> > Maciej> 2014-06-10  Maciej W. Rozycki  <macro@mips.com>
> > Maciej>             Maciej W. Rozycki  <macro@codesourcery.com>
> > 
> > Maciej> 	* lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'.
> > Maciej> 	* lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'.
> > 
> > I like Keith's proposed cleanup.
> > 
> > Maciej> +	set commands [target_info gdb_init_commands];
> > 
> > Extraneous ";".  There are a few of these.
> 
>  Sigh, it just shows my lack of experience with TCL back in 2005.  I've 
> been pondering an update to the change to avoid some code duplication, so 
> given I had to touch it anyway I went ahead and did it.  Here's the 
> result.
> 
>  It has been lightly tested with gdb.base/advance.exp, with neither 
> setting defined, with `gdb_init_command' only, with `gdb_init_commands' 
> only having a single element, with `gdb_init_commands' only having two 
> elements and with both `gdb_init_command' and `gdb_init_commands' defined, 
> the latter having two elements.  It has been also smoke-tested with 
> gdb.mi/mi-break.exp, with the last arrangement mentioned above only.
> 
> > I think this patch should also update testsuite/README to document the
> > new setting.
> 
>  And presumably the old one as well, right?  Cc-ing Eli for this part.
> 
> 2014-06-11  Maciej W. Rozycki  <macro@mips.com>
>             Maciej W. Rozycki  <macro@codesourcery.com>
> 
> 	* lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'.
> 	* lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'.
> 	* README (Board Settings): Document `gdb_init_command' and 
> 	`gdb_init_commands'.

 Ping.

  Maciej

  reply	other threads:[~2014-06-19 23:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 18:24 [PATCH] " Maciej W. Rozycki
2014-06-10 18:52 ` Keith Seitz
2014-06-11 15:39 ` Tom Tromey
2014-06-11 18:41   ` Maciej W. Rozycki
2014-06-19 23:39     ` Maciej W. Rozycki [this message]
2014-06-20  7:14       ` [PING][PATCH] " Eli Zaretskii
2014-06-20 22:53         ` Maciej W. Rozycki
2014-06-21  7:14           ` Eli Zaretskii
2014-06-23 14:03             ` Joel Brobecker
2014-06-20  8:50     ` [PATCH] " Pedro Alves
2014-07-10  0:17       ` [PATCH v2] " Maciej W. Rozycki
2014-07-10 16:15         ` Pedro Alves
2014-07-12  4:38           ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1406200028100.3924@tp.orcam.me.uk \
    --to=macro@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).