From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12119 invoked by alias); 19 Jun 2014 23:39:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12105 invoked by uid 89); 19 Jun 2014 23:39:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Jun 2014 23:39:45 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Wxlvg-0006CB-L7 from Maciej_Rozycki@mentor.com ; Thu, 19 Jun 2014 16:39:40 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 19 Jun 2014 16:39:40 -0700 Received: from localhost (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Fri, 20 Jun 2014 00:39:38 +0100 Date: Thu, 19 Jun 2014 23:39:00 -0000 From: "Maciej W. Rozycki" To: Tom Tromey CC: Keith Seitz , Eli Zaretskii , Subject: [PING][PATCH] GDB/testsuite: Add a way to send multiple init commands In-Reply-To: Message-ID: References: <87a99jwj4u.fsf@fleche.redhat.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-06/txt/msg00718.txt.bz2 On Wed, 11 Jun 2014, Maciej W. Rozycki wrote: > On Wed, 11 Jun 2014, Tom Tromey wrote: > > > Maciej> 2014-06-10 Maciej W. Rozycki > > Maciej> Maciej W. Rozycki > > > > Maciej> * lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'. > > Maciej> * lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'. > > > > I like Keith's proposed cleanup. > > > > Maciej> + set commands [target_info gdb_init_commands]; > > > > Extraneous ";". There are a few of these. > > Sigh, it just shows my lack of experience with TCL back in 2005. I've > been pondering an update to the change to avoid some code duplication, so > given I had to touch it anyway I went ahead and did it. Here's the > result. > > It has been lightly tested with gdb.base/advance.exp, with neither > setting defined, with `gdb_init_command' only, with `gdb_init_commands' > only having a single element, with `gdb_init_commands' only having two > elements and with both `gdb_init_command' and `gdb_init_commands' defined, > the latter having two elements. It has been also smoke-tested with > gdb.mi/mi-break.exp, with the last arrangement mentioned above only. > > > I think this patch should also update testsuite/README to document the > > new setting. > > And presumably the old one as well, right? Cc-ing Eli for this part. > > 2014-06-11 Maciej W. Rozycki > Maciej W. Rozycki > > * lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'. > * lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'. > * README (Board Settings): Document `gdb_init_command' and > `gdb_init_commands'. Ping. Maciej