From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>, Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [PATCH] Avoid software breakpoint's instruction shadow inconsistency
Date: Tue, 23 Sep 2014 18:34:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1409231930370.27075@tp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.1409231850520.27075@tp.orcam.me.uk>
On Tue, 23 Sep 2014, Maciej W. Rozycki wrote:
> > > This is also important for places
> > > like `find_single_step_breakpoint' where a breakpoint's address is
> > > compared to the raw value of $pc.
> > >
> >
> > AFAICS, insert_single_step_breakpoint also doesn't do
> > gdbarch_breakpoint_from_pc, so there doesn't seem to be a mismatch.
>
> The problem is `find_single_step_breakpoint' is called in the ordinary
> breakpoint removal path too, so that if a single-step breakpoint is placed
> at the same address, it is retained. I saw this place do bad things in
> testing my change before I adjusted it to use `reqstd_address'.
And this change alone is I believe what is responsible for the removal of
the following regressions:
FAIL: gdb.base/sss-bp-on-user-bp-2.exp: before/after disassembly matches
FAIL: gdb.base/sss-bp-on-user-bp-2.exp: stepi_del_break
in little-endian MIPS16 multilib testing and this regression:
FAIL: gdb.base/sss-bp-on-user-bp-2.exp: before/after disassembly matches
in big-endian MIPS16 multilib testing with this patch in place.
Maciej
next prev parent reply other threads:[~2014-09-23 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 17:08 Maciej W. Rozycki
2014-09-23 17:45 ` Pedro Alves
2014-09-23 18:11 ` Maciej W. Rozycki
2014-09-23 18:34 ` Maciej W. Rozycki [this message]
2014-09-29 18:29 ` Pedro Alves
2014-09-29 19:12 ` Maciej W. Rozycki
2014-09-29 20:22 ` Maciej W. Rozycki
2014-09-29 20:56 ` Pedro Alves
2014-10-03 11:57 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1409231930370.27075@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).