From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Doug Evans <xdje42@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Rich Fuhler <rich@mips.com>,
Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests
Date: Sun, 16 Nov 2014 20:05:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1411161957100.2881@tp.orcam.me.uk> (raw)
In-Reply-To: <m38ujbylie.fsf@sspiff.org>
On Sun, 16 Nov 2014, Doug Evans wrote:
> >>> Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S
> >>> ===================================================================
> >>> ---
> >>> gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S
> >>> 2014-10-02 07:56:23.000000000 +0100
> >>> +++
> >>> gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S
> >>> 2014-10-02 07:58:10.978958268 +0100
> >>> @@ -15,7 +15,8 @@
> >>>
> >>> .text
> >>> .globl main
> >>> -main: .byte 0
> >>> +main:
> >>> + .dc.l 0
> >>
> >> We've never used .dl.l before, and I don't know how widely available
> >> it is (in fact, I couldn't find it in the GAS manual). How about using
> >> .word or .4byte? It would also be consistent with what we've usually be
> >> using. Would that work?
> >
> > Agreed.
>
> Sorry for the followup, but FAOD, .4byte.
> .word may be a different size on some platforms.
If anything, that would have to be `.4byte'.
I chose `.dc.l' because it is the only fully portable GAS pseudo-op to
produce 32-bit data output. Testing portability was the actual reason
to add all the `.dc.*' pseudo-ops to GAS. As you've already observed
`.word' is unportable, and neither is `.4byte' as the latter is only
supported for ELF targets. However in DWARF-2 testing we're probably on
an ELF target anyway.
So I'll update the tests to use `.4byte'. Thanks for your review.
Maciej
next prev parent reply other threads:[~2014-11-16 20:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 15:37 [RFD+PATCH] ISA bit treatment on the MIPS platform Maciej W. Rozycki
2012-05-18 22:01 ` Maciej W. Rozycki
2012-06-11 18:21 ` Joel Brobecker
2012-06-12 14:05 ` Pedro Alves
2014-10-06 0:42 ` [PATCH v2 1/2] " Maciej W. Rozycki
2014-10-06 0:42 ` [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests Maciej W. Rozycki
2014-11-16 11:09 ` Joel Brobecker
2014-11-16 18:32 ` Doug Evans
2014-11-16 19:49 ` Doug Evans
2014-11-16 20:05 ` Maciej W. Rozycki [this message]
2014-11-16 21:52 ` Doug Evans
2014-12-04 0:24 ` Maciej W. Rozycki
2014-11-16 22:28 ` Doug Evans
2014-10-06 14:10 ` [PATCH v2 1/2] ISA bit treatment on the MIPS platform Joel Brobecker
2014-10-14 20:45 ` Maciej W. Rozycki
2014-10-20 17:10 ` [PING][PATCH " Maciej W. Rozycki
2014-11-03 16:13 ` [PING^2][PATCH " Maciej W. Rozycki
2014-11-16 19:23 ` [PATCH " Doug Evans
2014-10-06 15:43 ` Maciej W. Rozycki
2014-11-16 10:37 ` Joel Brobecker
2014-11-16 19:27 ` Doug Evans
2014-12-04 23:14 ` Maciej W. Rozycki
2014-12-12 14:00 ` Maciej W. Rozycki
2014-12-12 17:22 ` Doug Evans
2014-11-17 1:17 ` Doug Evans
2014-12-04 15:31 ` Maciej W. Rozycki
2014-12-12 16:38 ` [committed] MIPS: Define aliases for MSYMBOL_TARGET_FLAG macros Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1411161957100.2881@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=rdsandiford@googlemail.com \
--cc=rich@mips.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).