From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32686 invoked by alias); 16 Nov 2014 20:05:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32667 invoked by uid 89); 16 Nov 2014 20:05:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Nov 2014 20:05:54 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Xq64z-0002qJ-CK from Maciej_Rozycki@mentor.com ; Sun, 16 Nov 2014 12:05:49 -0800 Received: from localhost (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.3.181.6; Sun, 16 Nov 2014 20:05:47 +0000 Date: Sun, 16 Nov 2014 20:05:00 -0000 From: "Maciej W. Rozycki" To: Doug Evans CC: Joel Brobecker , "gdb-patches@sourceware.org" , Rich Fuhler , Richard Sandiford Subject: Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests In-Reply-To: Message-ID: References: <20120611182043.GA7597@adacore.com> <20141116110934.GH5774@adacore.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-11/txt/msg00382.txt.bz2 On Sun, 16 Nov 2014, Doug Evans wrote: > >>> Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S > >>> =================================================================== > >>> --- > >>> gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S > >>> 2014-10-02 07:56:23.000000000 +0100 > >>> +++ > >>> gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S > >>> 2014-10-02 07:58:10.978958268 +0100 > >>> @@ -15,7 +15,8 @@ > >>> > >>> .text > >>> .globl main > >>> -main: .byte 0 > >>> +main: > >>> + .dc.l 0 > >> > >> We've never used .dl.l before, and I don't know how widely available > >> it is (in fact, I couldn't find it in the GAS manual). How about using > >> .word or .4byte? It would also be consistent with what we've usually be > >> using. Would that work? > > > > Agreed. > > Sorry for the followup, but FAOD, .4byte. > .word may be a different size on some platforms. If anything, that would have to be `.4byte'. I chose `.dc.l' because it is the only fully portable GAS pseudo-op to produce 32-bit data output. Testing portability was the actual reason to add all the `.dc.*' pseudo-ops to GAS. As you've already observed `.word' is unportable, and neither is `.4byte' as the latter is only supported for ELF targets. However in DWARF-2 testing we're probably on an ELF target anyway. So I'll update the tests to use `.4byte'. Thanks for your review. Maciej