From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>, Doug Evans <xdje42@gmail.com>
Cc: <gdb-patches@sourceware.org>, Rich Fuhler <rich@mips.com>,
Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: [PATCH v2 1/2] ISA bit treatment on the MIPS platform
Date: Fri, 12 Dec 2014 14:00:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1412121354070.19155@tp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.1412042136450.19155@tp.orcam.me.uk>
Joel, Doug --
On Thu, 4 Dec 2014, Maciej W. Rozycki wrote:
> > This is not a requirement for your patch, but if you happen to be able
> > to quickly document elf_make_msymbol_special as well, that would be
> > a very welcome and appreciated change.
>
> I have now added these descriptions, with some bias towards the MIPS
> specifics as they are what I am most familiar with. Please let me know
> if you think they might be further improved.
I haven't heard back from you, so I have applied the change now.
While reviewing the final ChangeLog entry I discovered I created an
unneeded shadow local variable definition, so in addition to the changes
already posted in this thread I have included the following cleanup, as
obvious, in the final commit.
Thanks for your review.
Maciej
gdb-mips16-isa-bit-cleanup.diff
Index: gdb-fsf-trunk-quilt/gdb/dwarf2read.c
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/dwarf2read.c 2014-12-11 23:54:46.000000000 +0000
+++ gdb-fsf-trunk-quilt/gdb/dwarf2read.c 2014-12-12 00:21:46.768928206 +0000
@@ -7027,9 +7027,6 @@ add_partial_subprogram (struct partial_d
CORE_ADDR *lowpc, CORE_ADDR *highpc,
int set_addrmap, struct dwarf2_cu *cu)
{
- struct objfile *objfile = cu->objfile;
- struct gdbarch *gdbarch = get_objfile_arch (objfile);
-
if (pdi->tag == DW_TAG_subprogram)
{
if (pdi->has_pc_info)
@@ -7041,6 +7038,7 @@ add_partial_subprogram (struct partial_d
if (set_addrmap)
{
struct objfile *objfile = cu->objfile;
+ struct gdbarch *gdbarch = get_objfile_arch (objfile);
CORE_ADDR baseaddr;
CORE_ADDR highpc;
CORE_ADDR lowpc;
next prev parent reply other threads:[~2014-12-12 14:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 15:37 [RFD+PATCH] " Maciej W. Rozycki
2012-05-18 22:01 ` Maciej W. Rozycki
2012-06-11 18:21 ` Joel Brobecker
2012-06-12 14:05 ` Pedro Alves
2014-10-06 0:42 ` [PATCH v2 1/2] " Maciej W. Rozycki
2014-10-06 0:42 ` [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests Maciej W. Rozycki
2014-11-16 11:09 ` Joel Brobecker
2014-11-16 18:32 ` Doug Evans
2014-11-16 19:49 ` Doug Evans
2014-11-16 20:05 ` Maciej W. Rozycki
2014-11-16 21:52 ` Doug Evans
2014-12-04 0:24 ` Maciej W. Rozycki
2014-11-16 22:28 ` Doug Evans
2014-10-06 14:10 ` [PATCH v2 1/2] ISA bit treatment on the MIPS platform Joel Brobecker
2014-10-14 20:45 ` Maciej W. Rozycki
2014-10-20 17:10 ` [PING][PATCH " Maciej W. Rozycki
2014-11-03 16:13 ` [PING^2][PATCH " Maciej W. Rozycki
2014-11-16 19:23 ` [PATCH " Doug Evans
2014-10-06 15:43 ` Maciej W. Rozycki
2014-11-16 10:37 ` Joel Brobecker
2014-11-16 19:27 ` Doug Evans
2014-12-04 23:14 ` Maciej W. Rozycki
2014-12-12 14:00 ` Maciej W. Rozycki [this message]
2014-12-12 17:22 ` Doug Evans
2014-11-17 1:17 ` Doug Evans
2014-12-04 15:31 ` Maciej W. Rozycki
2014-12-12 16:38 ` [committed] MIPS: Define aliases for MSYMBOL_TARGET_FLAG macros Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1412121354070.19155@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=rdsandiford@googlemail.com \
--cc=rich@mips.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).