From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>, Rich Fuhler <rich@mips.com>,
Richard Sandiford <rdsandiford@googlemail.com>
Subject: [committed] MIPS: Define aliases for MSYMBOL_TARGET_FLAG macros
Date: Fri, 12 Dec 2014 16:38:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1412121630040.19155@tp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.1409292313170.4971@tp.orcam.me.uk>
On Mon, 6 Oct 2014, Maciej W. Rozycki wrote:
> > Just some minor comments below:
> >
> > > gdb-mips16-isa-bit.diff
> > > Index: gdb-fsf-trunk-quilt/gdb/mips-tdep.c
> > > ===================================================================
> > > --- gdb-fsf-trunk-quilt.orig/gdb/mips-tdep.c 2012-05-14 16:00:33.000000000 +0100
> > > +++ gdb-fsf-trunk-quilt/gdb/mips-tdep.c 2012-05-14 16:02:02.235560558 +0100
> > > @@ -358,9 +358,15 @@ mips_elf_make_msymbol_special (asymbol *
> > > return;
> > >
> > > if (ELF_ST_IS_MICROMIPS (elfsym->internal_elf_sym.st_other))
> > > - MSYMBOL_TARGET_FLAG_2 (msym) = 1;
> > > + {
> > > + MSYMBOL_TARGET_FLAG_2 (msym) = 1;
> > > + SYMBOL_VALUE_ADDRESS (msym) |= 1;
> > > + }
> > > else if (ELF_ST_IS_MIPS16 (elfsym->internal_elf_sym.st_other))
> > > - MSYMBOL_TARGET_FLAG_1 (msym) = 1;
> > > + {
> > > + MSYMBOL_TARGET_FLAG_1 (msym) = 1;
> > > + SYMBOL_VALUE_ADDRESS (msym) |= 1;
> > > + }
> >
> > This remark is not to be considered as part of this patch's review,
> > since this is already an established practice, but I think we could do
> > better than using magic numbers for those flags. I understand they have
> > to be that way in the common code, but perhaps mips-tdep could define
> > aliases? Something like MSYMBOL_MIPS_TARGET_FLAG_BLAH?
>
> Good point, I'll push such a change as a followup; I have it ready now.
I have committed this change now.
2014-12-12 Maciej W. Rozycki <macro@codesourcery.com>
gdb/
* mips-tdep.h (MSYMBOL_TARGET_FLAG_MIPS16): New macro.
(MSYMBOL_TARGET_FLAG_MICROMIPS): Likewise.
* mips-tdep.c (mips_elf_make_msymbol_special): Use the new
macros.
(msymbol_is_mips, msymbol_is_mips16, msymbol_is_micromips):
Likewise.
Maciej
gdb-mips-msymbol-target-flag.diff
Index: gdb-fsf-trunk-quilt/gdb/mips-tdep.c
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/mips-tdep.c 2014-10-03 14:50:26.398945943 +0100
+++ gdb-fsf-trunk-quilt/gdb/mips-tdep.c 2014-10-03 14:50:26.398945943 +0100
@@ -379,12 +379,12 @@ mips_elf_make_msymbol_special (asymbol *
if (ELF_ST_IS_MICROMIPS (st_other))
{
- MSYMBOL_TARGET_FLAG_2 (msym) = 1;
+ MSYMBOL_TARGET_FLAG_MICROMIPS (msym) = 1;
SET_MSYMBOL_VALUE_ADDRESS (msym, MSYMBOL_VALUE_RAW_ADDRESS (msym) | 1);
}
else if (ELF_ST_IS_MIPS16 (st_other))
{
- MSYMBOL_TARGET_FLAG_1 (msym) = 1;
+ MSYMBOL_TARGET_FLAG_MIPS16 (msym) = 1;
SET_MSYMBOL_VALUE_ADDRESS (msym, MSYMBOL_VALUE_RAW_ADDRESS (msym) | 1);
}
}
@@ -394,7 +394,8 @@ mips_elf_make_msymbol_special (asymbol *
static int
msymbol_is_mips (struct minimal_symbol *msym)
{
- return !(MSYMBOL_TARGET_FLAG_1 (msym) | MSYMBOL_TARGET_FLAG_2 (msym));
+ return !(MSYMBOL_TARGET_FLAG_MIPS16 (msym)
+ | MSYMBOL_TARGET_FLAG_MICROMIPS (msym));
}
/* Return one iff MSYM refers to MIPS16 code. */
@@ -402,7 +403,7 @@ msymbol_is_mips (struct minimal_symbol *
static int
msymbol_is_mips16 (struct minimal_symbol *msym)
{
- return MSYMBOL_TARGET_FLAG_1 (msym);
+ return MSYMBOL_TARGET_FLAG_MIPS16 (msym);
}
/* Return one iff MSYM refers to microMIPS code. */
@@ -410,7 +411,7 @@ msymbol_is_mips16 (struct minimal_symbol
static int
msymbol_is_micromips (struct minimal_symbol *msym)
{
- return MSYMBOL_TARGET_FLAG_2 (msym);
+ return MSYMBOL_TARGET_FLAG_MICROMIPS (msym);
}
/* Set the ISA bit in the main symbol too, complementing the corresponding
Index: gdb-fsf-trunk-quilt/gdb/mips-tdep.h
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/mips-tdep.h 2014-10-03 14:50:26.398945943 +0100
+++ gdb-fsf-trunk-quilt/gdb/mips-tdep.h 2014-10-03 14:50:26.398945943 +0100
@@ -48,6 +48,10 @@ enum mips_isa
ISA_MICROMIPS
};
+/* Corresponding MSYMBOL_TARGET_FLAG aliases. */
+#define MSYMBOL_TARGET_FLAG_MIPS16 MSYMBOL_TARGET_FLAG_1
+#define MSYMBOL_TARGET_FLAG_MICROMIPS MSYMBOL_TARGET_FLAG_2
+
/* Return the MIPS ISA's register size. Just a short cut to the BFD
architecture's word size. */
extern int mips_isa_regsize (struct gdbarch *gdbarch);
prev parent reply other threads:[~2014-12-12 16:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 15:37 [RFD+PATCH] ISA bit treatment on the MIPS platform Maciej W. Rozycki
2012-05-18 22:01 ` Maciej W. Rozycki
2012-06-11 18:21 ` Joel Brobecker
2012-06-12 14:05 ` Pedro Alves
2014-10-06 0:42 ` [PATCH v2 1/2] " Maciej W. Rozycki
2014-10-06 0:42 ` [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests Maciej W. Rozycki
2014-11-16 11:09 ` Joel Brobecker
2014-11-16 18:32 ` Doug Evans
2014-11-16 19:49 ` Doug Evans
2014-11-16 20:05 ` Maciej W. Rozycki
2014-11-16 21:52 ` Doug Evans
2014-12-04 0:24 ` Maciej W. Rozycki
2014-11-16 22:28 ` Doug Evans
2014-10-06 14:10 ` [PATCH v2 1/2] ISA bit treatment on the MIPS platform Joel Brobecker
2014-10-14 20:45 ` Maciej W. Rozycki
2014-10-20 17:10 ` [PING][PATCH " Maciej W. Rozycki
2014-11-03 16:13 ` [PING^2][PATCH " Maciej W. Rozycki
2014-11-16 19:23 ` [PATCH " Doug Evans
2014-10-06 15:43 ` Maciej W. Rozycki
2014-11-16 10:37 ` Joel Brobecker
2014-11-16 19:27 ` Doug Evans
2014-12-04 23:14 ` Maciej W. Rozycki
2014-12-12 14:00 ` Maciej W. Rozycki
2014-12-12 17:22 ` Doug Evans
2014-11-17 1:17 ` Doug Evans
2014-12-04 15:31 ` Maciej W. Rozycki
2014-12-12 16:38 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1412121630040.19155@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=rdsandiford@googlemail.com \
--cc=rich@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).