From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71795 invoked by alias); 12 Jun 2017 15:25:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71780 invoked by uid 89); 12 Jun 2017 15:25:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Bear, our X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Jun 2017 15:25:18 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id 03FDB80BE54CD; Mon, 12 Jun 2017 16:25:17 +0100 (IST) Received: from [10.20.78.192] (10.20.78.192) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Mon, 12 Jun 2017 16:25:19 +0100 Date: Mon, 12 Jun 2017 15:25:00 -0000 From: "Maciej W. Rozycki" To: Yao Qi CC: Subject: Re: [PATCH 01/25] Move initialize_tdesc_mips* calls from mips-linux-nat.c to mips-linux-tdep.c In-Reply-To: <1497256916-4958-2-git-send-email-yao.qi@linaro.org> Message-ID: References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-2-git-send-email-yao.qi@linaro.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2017-06/txt/msg00318.txt.bz2 On Mon, 12 Jun 2017, Yao Qi wrote: > All target descriptions except mips initialization are called in -tdep.c, > instead of -nat.c, so this patch moves mips target descriptions initialization > to -tdep.c. Secondly, I want to change the target descriptions from pre-generated > to dynamical creation, so I want to test that these pre-generated target > descriptions equal to these dynamically created ones. Move target descriptions > initialization to -tdep.c files so we can test them in any hosts (if they are > still -nat.c, we can only test them on mips-linux host.). Can you please wrap the commit description such that it does not go past 80th column? Bear in mind that GIT indents by 4 characters, but if you stick to our general 74-column rule for text you'll be good. Otherwise LGTM. Maciej