From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54296 invoked by alias); 18 Oct 2017 13:37:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54278 invoked by uid 89); 18 Oct 2017 13:37:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=consequently, indicator X-Spam-User: qpsmtpd, 2 recipients X-HELO: 20pmail.ess.barracuda.com Received: from 20pmail.ess.barracuda.com (HELO 20pmail.ess.barracuda.com) (64.235.154.233) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Oct 2017 13:37:54 +0000 Received: from MIPSMAIL01.mipstec.com (mailrelay.mips.com [12.201.5.28]) by mx1401.ess.rzc.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO); Wed, 18 Oct 2017 13:36:59 +0000 Received: from [10.20.78.218] (10.20.78.218) by mips01.mipstec.com (10.20.43.31) with Microsoft SMTP Server id 14.3.361.1; Wed, 18 Oct 2017 06:34:54 -0700 Date: Wed, 18 Oct 2017 13:37:00 -0000 From: "Maciej W. Rozycki" To: Djordje Todorovic , Pedro Alves CC: , , , , , Subject: Re: [PATCH 3/3] Add test for fetching TLS from core file In-Reply-To: <1508248194-26950-3-git-send-email-djordje.todorovic@rt-rk.com> Message-ID: References: <1508248194-26950-1-git-send-email-djordje.todorovic@rt-rk.com> <1508248194-26950-3-git-send-email-djordje.todorovic@rt-rk.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-BESS-ID: 1508333751-321457-32085-62641-8 X-BESS-VER: 2017.12-r1710102214 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.186087 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status:1 X-SW-Source: 2017-10/txt/msg00566.txt.bz2 On Tue, 17 Oct 2017, Djordje Todorovic wrote: > diff --git a/gdb/testsuite/gdb.threads/tls-core.c b/gdb/testsuite/gdb.threads/tls-core.c > new file mode 100644 > index 0000000..e41c584 > --- /dev/null > +++ b/gdb/testsuite/gdb.threads/tls-core.c > @@ -0,0 +1,44 @@ > +/* This test is part of GDB, the GNU debugger. > + > + Copyright 2017 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include > +#include > +#include > +#include > + > +#define NUMBER_OF_THREADS 5 > + > +int __thread foo = 0xdeadbeef; > + > +void * > +thread (void *in) /* BREAK */ > +{ > + int *tmp = (int *) in; > + int value = *tmp; > + foo += *tmp; > + while (1) > + sleep (10); > +} > + > +int > +main (void) > +{ > + pthread_t threads[NUMBER_OF_THREADS]; > + int i; > + for (i = 0; i < NUMBER_OF_THREADS; i++) > + pthread_create (&threads[i], NULL, thread, &i); Missing `return' statement here. Also `while (1) sleep (10);' perhaps, so that you don't cause a race with the whole process terminating (I think `pthread_join (&threads[0], NULL);' would do too; I'm sure there are other ways as well to prevent from running to exit(2)). Overall please don't assume any particular thread scheduling characteristics of the underlying OS, and especially on SMP systems effects may be sometimes surprising. > +} > \ No newline at end of file Missing new line here. > diff --git a/gdb/testsuite/gdb.threads/tls-core.exp b/gdb/testsuite/gdb.threads/tls-core.exp > new file mode 100644 > index 0000000..dc291ab > --- /dev/null > +++ b/gdb/testsuite/gdb.threads/tls-core.exp > @@ -0,0 +1,60 @@ > +# Copyright 2017 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +standard_testfile > + > +if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ > + executable { debug }] != "" } { Formatting: space after a tab here. > + return -1 > +} > + > + > +clean_restart ${binfile} > + > +# > +# Set breakpoint at line 28. > +# > +gdb_breakpoint [gdb_get_line_number "BREAK"] > +gdb_test "run" "Starting program: .*" The `run' command isn't supported with all targets and we do not wan't to cause a test failure unrelated to the matter being verified. Please use `runto_main' then, i.e.: clean_restart ${binfile} runto_main Sorry to miss that before. Also since you set a breakpoint at a function (which wasn't evident before) you should be able to simplify processing and just use: runto thread instead of going through the dance to set and catch the breakpoint manually. > + > +# > +# Generate corefile. > +# > +set corefile [standard_output_file gcore.test] > +set core_supported [gdb_gcore_cmd "$corefile" "save a corefile"] > +if {!$core_supported} { > + return -1 > +} > + > +gdb_exit > + > +# > +# Restart gdb and load generated corefile. > +# > +gdb_start > +gdb_reinitialize_dir $srcdir/$subdir > +gdb_load ${binfile} > + > +set core_loaded [gdb_core_cmd "$corefile" "load generated corefile"] > +if { $core_loaded == -1 } { I think this has to be `$core_loaded != 1' or suchlike as I doubt a core file with no registers recorded will be usable for the actual test being made here. I missed this peculiarity before, sorry. > + # No use proceeding from here. > + return I missed this on the previous iteration, sorry: why no return result here (i.e. an empty string being returned) vs -1 elsewhere? I don't think we have a clear rule for return results defined and moreover the caller actually ignores it. Regardless, we set the result, differently, across the test suite. The value of -1 seems to be used as an indicator of a fatal test processing failure, such as with the first `return' statement above. And in the case of a failure `gdb_compile_pthreads' will have already called `unsupported', so there's nothing else for us to do here. The second `return' statement is neither a fatal test processing failure nor a test failure. It merely marks the `gcore' feature not being supported and consequently the inability to continue with the test case. In this case `gdb_gcore_cmd' will have already called `unsupported' as expected. So I think it should return 0 or nothing (i.e. an empty string). The third `return' statement actually marks a test failure, because GDB is supposed to be able to load a core file in all cases, but not a fatal test processing failure. Again in this case `gdb_core_cmd' will have already called `fail' as expected. So again I think it should return 0 or nothing. I'd like to hear from a general maintainer about this though. Pedro, would you be able to comment on my observations and, ultimately (once the details have been sorted out), approve this change (as technically it's outside my area of competence anyway)? > +} > + > +gdb_test "p/x foo" \ > + "\\$\[0-9]+ = 0xdeadbeef" \ > + "Printing thread-local storage variable." Formatting: use tabs rather than spaces to indent; one per line will do. Please wait a couple of days to give Pedro an opportunity to chime in and then resubmit the whole series with the details above and 1/3 updated. Maciej