From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9804 invoked by alias); 26 Feb 2018 21:58:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9794 invoked by uid 89); 26 Feb 2018 21:58:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=scored X-HELO: 9pmail.ess.barracuda.com Received: from 9pmail.ess.barracuda.com (HELO 9pmail.ess.barracuda.com) (64.235.154.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 21:58:40 +0000 Received: from MIPSMAIL01.mipstec.com (mailrelay.mips.com [12.201.5.28]) by mx1401.ess.rzc.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO); Mon, 26 Feb 2018 21:58:32 +0000 Received: from [10.20.78.94] (10.20.78.94) by mips01.mipstec.com (10.20.43.31) with Microsoft SMTP Server id 14.3.361.1; Mon, 26 Feb 2018 13:55:25 -0800 Date: Mon, 26 Feb 2018 21:58:00 -0000 From: "Maciej W. Rozycki" To: "Metzger, Markus T" CC: Andreas Arnez , "gdb-patches@sourceware.org" Subject: Re: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method In-Reply-To: Message-ID: References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-6-git-send-email-markus.t.metzger@intel.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-BESS-ID: 1519682309-321457-17244-3398-4 X-BESS-VER: 2018.2-r1802232356 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.190452 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status:1 X-SW-Source: 2018-02/txt/msg00406.txt.bz2 Hi Markus, Thank you for the quick action on this problem. On Mon, 26 Feb 2018, Andreas Arnez wrote: > >> Process .../gdb/testsuite/outputs/gdb.base/advance/advance created; pid = > >> 25519 Listening on port 2346 target remote 1.2.3.4:2346 Remote debugging using > >> 1.2.3.4:2346 Reading symbols from .../lib/ld.so.1...done. > >> 0x77fc8de0 in __start () from .../lib/ld.so.1 Protocol error: qXfer:btrace-conf > >> (read-btrace-conf) conflicting enabled responses. > >> (gdb) continue > >> The program is not being run. > >> (gdb) FAIL: gdb.base/advance.exp: can't run to main > >> > >> See the attached RSP packet exchange log for details. Please investigate. > > For the record, the same happens on s390x. It seems that you broke all > targets without HAVE_LINUX_BTRACE. I suspected that might be the case. With your future changes that touch generic code would you please regression-test them with another target, or at least ask people to do so before committing them, so that such a wide breakage is avoided? Having several versions not working at all makes it a pain to bisect changes that may have caused regressions meanwhile. Also did you verify that old-GDB/new-gdbserver and new-GDB/old-gdbserver combinations work correctly? > > Below is a patch to address this. I tested it on IA by undefining HAVE_LINUX_BTRACE. > > Does it fix the issue you reported? > > I've tested your patch on s390x, and it seems to fix the problem. I have smoke-tested your change with `gdb.base/advance.exp' and one of the configurations that failed previously, and it has scored all-pass now. I'll schedule full testing overnight. Maciej