public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: <gdb-patches@sourceware.org>
Subject: [committed] MIPS: Make `mask_address_var' static
Date: Tue, 15 May 2018 16:59:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1805151556510.10896@tp.orcam.me.uk> (raw)

Make the `mask_address_var' variable static, it is not used outside 
mips-tdep.c and having no target name embedded within it causes a risk 
of a namespace clash.

	gdb/
	* mips-tdep.c (mask_address_var): Make variable static.
---
 gdb/mips-tdep.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

gdb-mips-mask-address-var-static.diff
Index: binutils/gdb/mips-tdep.c
===================================================================
--- binutils.orig/gdb/mips-tdep.c	2018-04-16 13:54:45.000000000 +0100
+++ binutils/gdb/mips-tdep.c	2018-04-16 15:19:15.149150666 +0100
@@ -1122,7 +1122,7 @@ mips_pseudo_register_type (struct gdbarc
 }
 
 /* Should the upper word of 64-bit addresses be zeroed?  */
-enum auto_boolean mask_address_var = AUTO_BOOLEAN_AUTO;
+static enum auto_boolean mask_address_var = AUTO_BOOLEAN_AUTO;
 
 static int
 mips_mask_address_p (struct gdbarch_tdep *tdep)

                 reply	other threads:[~2018-05-15 15:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1805151556510.10896@tp.orcam.me.uk \
    --to=macro@mips.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).