public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [committed] MIPS: Make `mask_address_var' static
@ 2018-05-15 16:59 Maciej W. Rozycki
  0 siblings, 0 replies; only message in thread
From: Maciej W. Rozycki @ 2018-05-15 16:59 UTC (permalink / raw)
  To: gdb-patches

Make the `mask_address_var' variable static, it is not used outside 
mips-tdep.c and having no target name embedded within it causes a risk 
of a namespace clash.

	gdb/
	* mips-tdep.c (mask_address_var): Make variable static.
---
 gdb/mips-tdep.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

gdb-mips-mask-address-var-static.diff
Index: binutils/gdb/mips-tdep.c
===================================================================
--- binutils.orig/gdb/mips-tdep.c	2018-04-16 13:54:45.000000000 +0100
+++ binutils/gdb/mips-tdep.c	2018-04-16 15:19:15.149150666 +0100
@@ -1122,7 +1122,7 @@ mips_pseudo_register_type (struct gdbarc
 }
 
 /* Should the upper word of 64-bit addresses be zeroed?  */
-enum auto_boolean mask_address_var = AUTO_BOOLEAN_AUTO;
+static enum auto_boolean mask_address_var = AUTO_BOOLEAN_AUTO;
 
 static int
 mips_mask_address_p (struct gdbarch_tdep *tdep)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-05-15 15:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 16:59 [committed] MIPS: Make `mask_address_var' static Maciej W. Rozycki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).