From: "Maciej W. Rozycki" <macro@mips.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>,
Djordje Todorovic <djordje.todorovic@rt-rk.com>
Subject: Re: [PATCH] testsuite: Extend TLS core file testing with an OS-generated dump
Date: Wed, 23 May 2018 23:59:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1805231550010.10896@tp.orcam.me.uk> (raw)
In-Reply-To: <f6250fa2-d10a-873d-52ab-7dc30807a141@redhat.com>
Hi Pedro,
> > Acknowledged. Given the current situation I cannot afford investing
> > any further work into this change, so let's ditch it (and a change to
> > gdb.base/auxv.exp to use `use_gdb_stub' I planned to submit next). If I
> > find some time after all, then I can revisit the decision later on.
> I understand. Let me take it over then. Below's a version using
> core_find.
>
> I also simplified the patch a bit:
>
> - Removed the rlimit bits, since it seems that no other core-related test
> does that (so it seems to me that if needed, it would better be done
> separately and to several testcases at once).
Well, I took them from gdb.base/auxv.c, so clearly there's at least one
test that has them. Perhaps you could modernise gdb.base/auxv.exp too?
> As a local hack, I flipped the logic in:
> set core_supported [expr {$corefile != ""}]
> to make sure that the expected UNSUPPORTED messages come out.
>
> Let me know what you think.
I'd keep that:
rename tls_core_test ""
command that I added at the end though, so as not to clutter the procedure
space. Otherwise it'll stay there thoughout the rest of a test suite run
(we have some leftover clutter in the testsuite already, which sometimes
makes different .exp scripts interact with each other).
I ran it native and gdbserver-native, and remote, with correct results.
Messages in the commit description need to be updated though, as below:
> This adds:
>
> PASS: gdb.threads/tls-core.exp: set cwd to temporary directory for core dumps
> PASS: gdb.threads/tls-core.exp: continue to signal
> PASS: gdb.threads/tls-core.exp: continue to termination
> PASS: gdb.threads/tls-core.exp: generate native core dump
> PASS: gdb.threads/tls-core.exp: load native corefile
> PASS: gdb.threads/tls-core.exp: print thread-local storage variable from native corefile
PASS: gdb.threads/tls-core.exp: native: load core file
PASS: gdb.threads/tls-core.exp: native: print thread-local storage variable
here, and:
> to local testing and:
>
> UNSUPPORTED: gdb.threads/tls-core.exp: generate native core dump
> UNSUPPORTED: gdb.threads/tls-core.exp: load native corefile
> UNSUPPORTED: gdb.threads/tls-core.exp: print thread-local storage variable from native corefile
WARNING: can't generate a core file - core tests suppressed - check ulimit -c
UNSUPPORTED: gdb.threads/tls-core.exp: native: load core file
UNSUPPORTED: gdb.threads/tls-core.exp: native: print thread-local storage variable
here. Will you handle all this or shall I?
Many thanks for taking care of this. Your updated test script actually
helped me greatly with a test case for the next change I am going to push
(another MIPS/Linux core file mishandling -- we live in a reality separate
from the kernel's as it turns out).
Maciej
next prev parent reply other threads:[~2018-05-23 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 4:59 Maciej W. Rozycki
2018-05-23 8:50 ` Djordje Todorovic
2018-05-23 13:35 ` Pedro Alves
2018-05-23 14:17 ` Maciej W. Rozycki
2018-05-23 17:33 ` Pedro Alves
2018-05-23 23:59 ` Maciej W. Rozycki [this message]
2018-05-24 15:05 ` Pedro Alves
2018-05-25 13:49 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1805231550010.10896@tp.orcam.me.uk \
--to=macro@mips.com \
--cc=djordje.todorovic@rt-rk.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).