From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44208 invoked by alias); 21 Jun 2018 18:29:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44184 invoked by uid 89); 21 Jun 2018 18:29:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=glance, H*i:sk:3bd95a5, H*f:sk:3bd95a5 X-Spam-User: qpsmtpd, 2 recipients X-HELO: 9pmail.ess.barracuda.com Received: from 9pmail.ess.barracuda.com (HELO 9pmail.ess.barracuda.com) (64.235.150.224) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 18:29:04 +0000 Received: from mipsdag02.mipstec.com (mail2.mips.com [12.201.5.32]) by mx30.ess.sfj.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=NO); Thu, 21 Jun 2018 18:28:45 +0000 Received: from [10.20.78.194] (10.20.78.194) by mipsdag02.mipstec.com (10.20.40.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Thu, 21 Jun 2018 11:28:42 -0700 Date: Thu, 21 Jun 2018 18:29:00 -0000 From: "Maciej W. Rozycki" To: Simon Marchi CC: Simon Marchi , , , Joel Brobecker , Fredrik Noring Subject: Re: [PATCH v4] GDB PR tdep/8282: MIPS: Wire in `set disassembler-options' In-Reply-To: <3bd95a5f-e43e-2efe-e261-c2cf30d06d14@ericsson.com> Message-ID: References: <3bd95a5f-e43e-2efe-e261-c2cf30d06d14@ericsson.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: mipsdag02.mipstec.com (10.20.40.47) To mipsdag02.mipstec.com (10.20.40.47) X-BESS-ID: 1529605724-637140-32670-105451-1 X-BESS-VER: 2018.7-r1806151722 X-BESS-Apparent-Source-IP: 12.201.5.32 X-BESS-Envelope-From: Maciej.Rozycki@mips.com X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-Orig-Rcpt: simon.marchi@ericsson.com,simon.marchi@polymtl.ca,gdb-patches@sourceware.org,binutils@sourceware.org,brobecker@adacore.com,noring@nocrew.org X-BESS-BRTS-Status:1 X-SW-Source: 2018-06/txt/msg00528.txt.bz2 Hi Simon, > This patch looks good from the GDB side (with one nit in the test below), but > somebody from binutils would need to review the bits in opcodes/include. Yes, that's why I requested it separately and posted to both mailing lists. > > +# Verify ABI overrides. > > +mips_disassemble_test bar "move\t\\\$2,\\\$8" "disassemble ABI (numeric)" > > +gdb_test "set disassembler-options" > > +gdb_test "set mips abi o32" > > +mips_disassemble_test bar "move\tv0,t0" "disassemble ABI (o32)" > > +gdb_test "set mips abi n32" > > +mips_disassemble_test bar "move\tv0,a4" "disassemble ABI (n32)" > > +gdb_test "set mips abi n64" > > +mips_disassemble_test bar "move\tv0,a4" "disassemble ABI (n64)" > > Avoid parenthesis at the end of test names: > > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages Thanks for the pointer. Although it makes sense to me at first glance that's quite a recent change to a long-established practice. Perhaps it could have been avoided by coding the regression analysis tools referred more carefully, but I won't be questioning the decision at this point. The wiki does not indicate a suggested replacement however and I would rather avoid creating a mess where individual tests would use different approaches. Offhand I'd be inclined to use brackets, either square or angled. What has been the new practice then? Maciej