From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14200 invoked by alias); 21 Jun 2018 19:56:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14161 invoked by uid 89); 21 Jun 2018 19:56:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:5d5b6d4, H*f:sk:5d5b6d4 X-Spam-User: qpsmtpd, 2 recipients X-HELO: 9pmail.ess.barracuda.com Received: from 9pmail.ess.barracuda.com (HELO 9pmail.ess.barracuda.com) (64.235.154.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 19:55:59 +0000 Received: from mipsdag02.mipstec.com (mail2.mips.com [12.201.5.32]) by mx1401.ess.rzc.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=NO); Thu, 21 Jun 2018 19:55:41 +0000 Received: from [10.20.78.194] (10.20.78.194) by mipsdag02.mipstec.com (10.20.40.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Thu, 21 Jun 2018 12:55:38 -0700 Date: Thu, 21 Jun 2018 19:56:00 -0000 From: "Maciej W. Rozycki" To: Simon Marchi CC: Simon Marchi , , , Joel Brobecker , Fredrik Noring Subject: Re: [PATCH v4] GDB PR tdep/8282: MIPS: Wire in `set disassembler-options' In-Reply-To: <5d5b6d47508d5f54ff2eb6e514a7da2c@polymtl.ca> Message-ID: References: <3bd95a5f-e43e-2efe-e261-c2cf30d06d14@ericsson.com> <5d5b6d47508d5f54ff2eb6e514a7da2c@polymtl.ca> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: mipsdag02.mipstec.com (10.20.40.47) To mipsdag02.mipstec.com (10.20.40.47) X-BESS-ID: 1529610940-321457-7401-21700-1 X-BESS-VER: 2018.7-r1806151722 X-BESS-Apparent-Source-IP: 12.201.5.32 X-BESS-Envelope-From: Maciej.Rozycki@mips.com X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-Orig-Rcpt: simon.marchi@polymtl.ca,simon.marchi@ericsson.com,gdb-patches@sourceware.org,binutils@sourceware.org,brobecker@adacore.com,noring@nocrew.org X-BESS-BRTS-Status:1 X-SW-Source: 2018-06/txt/msg00531.txt.bz2 On Thu, 21 Jun 2018, Simon Marchi wrote: > > Thanks for the pointer. Although it makes sense to me at first glance > > that's quite a recent change to a long-established practice. Perhaps it > > could have been avoided by coding the regression analysis tools referred > > more carefully, but I won't be questioning the decision at this point. > > That's because of how DejaGNU formats test messages, for example when there is > a timeout (as shown in the example on the wiki). We don't have control over > that, and we don't want "foo" and "foo (timeout)" to be considered as two > different tests. I think you chose the wrong example, after all what's the problem for tools to notice that "foo (bar)" and "foo (bar) (timeout)" are the same test? If the number of parenthesis pairs is different between two messages, then strip the extra ones along with the text between from the message that has more of them and only then compare the resulting strings. What the problem would be are different failures in different runs, e.g. if we have "foo (bar) (timeout)" in one and "foo (bar) (internal error)" in the other one, then indeed we have an issue. We could strip parenthesis pairs one by one from both messages at a time, but then we'd incorrectly consider "foo (bar)" and "foo (baz)" the same test. Does it matter in reality? I suppose so, given the outcome of the discussion referred from the wiki, although I don't see the scenario I have outlined here actually mentioned there (parts of the discussion seem to be missing though from the archive). > That does not really apply to your case though. I think here you can just > remove the parenthesis, and maybe add a comma. > > mips_disassemble_test bar "move\tv0,a4" "disassemble ABI, n64" > > As long as it's clear. OK, works for me. I'll make that adjustment as I commit the change once the binutils parts have been approved. Thank you for your review. Maciej