public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Sergey Korolev <s.korolev@ndmsystems.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] MIPS/GDB/linux-nat.c: Fix a child detach condition for uClibc-ng
Date: Mon, 09 Jul 2018 11:20:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1807091158030.30992@tp.orcam.me.uk> (raw)
In-Reply-To: <20180706220955.GP2675@embecosm.com>

On Fri, 6 Jul 2018, Andrew Burgess wrote:

> The problem is that signal 0x00 isn't coming from the kernel, it's
> being synthesised in GDB with 'W_STOPCODE (0)', which builds the
> status 007f.

 Right, somehow I didn't fully realise that it is GDB being responsible 
for creating this status code artificially.  Sorry for the confusion.

> I might even be bold enough to declare that 'W_STOPCODE (0)' should be
> declare a bad thing .... maybe ...

 I think it would be reasonable for an implementation to require the 
argument to be a valid signal number and therefore users of this API 
would have to avoid passing other numbers as that would cause undefined 
behaviour.

> Still, I don't see how uClibc-ng is doing anything wrong, a status is
> only a stop status if (a) it ends in 0x7f, and (b) the signal number
> is non-zero, this seems pretty reasonable really.

 Agreed.  Garbage in, garbage out.

  Maciej

  reply	other threads:[~2018-07-09 11:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 22:54 Sergey Korolev
2018-07-03 19:38 ` Andrew Burgess
2018-07-04 13:36   ` Sergey Korolev
2018-07-05 12:32   ` Maciej W. Rozycki
2018-07-05 21:05     ` Sergey Korolev
2018-07-06 22:10     ` Andrew Burgess
2018-07-09 11:20       ` Maciej W. Rozycki [this message]
2018-08-01 21:31   ` Ping! " Andrew Burgess
2018-08-01 21:38     ` Sergey Korolev
2018-08-02 20:03       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1807091158030.30992@tp.orcam.me.uk \
    --to=macro@mips.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=s.korolev@ndmsystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).