From: Joseph Myers <joseph@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
GDB <gdb-patches@sourceware.org>,
Binutils <binutils@sourceware.org>
Subject: Re: RFC: using AdaCore's git hooks for binutils-gdb.git ...
Date: Fri, 28 Nov 2014 18:06:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.10.1411281801250.18562@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CAMe9rOpCRmcK+uZ0j7gmqk1V6rQvuSw21q+Atewz83KvNpe0uA@mail.gmail.com>
On Fri, 28 Nov 2014, H.J. Lu wrote:
> Do we need to show the whole diff in the commit email? I think
> a commit URL should be sufficient. Binutils-gdb commit
> can have a very large commit diff due to generated files.
For glibc we show the diff in the email to glibc-cvs, but *not* in the
Bugzilla update (I'm not sure if the Bugzilla update works via sending
emails to each bug whose number was extracted from the commit message, or
by some other interface - but in any case, different messages are used for
the two cases). Obviously you'd want to make sure that the patterns used
to extract bug numbers are compatible with all those commonly used for
binutils and GDB at present.
In the early days of glibc git, sending the diff did result in at least
one 500MB email to glibc-cvs when the hook decided some branch commit
required the whole history (or at least the whole source tree) to be
emailed out, but I haven't seen such problems lately.
I don't know if binutils-gdb uses the whitespace checks that glibc does
(but again, you'd probably want to be compatible with the existing logic).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2014-11-28 18:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 13:58 Joel Brobecker
2014-11-28 14:08 ` H.J. Lu
2014-11-28 14:27 ` Joel Brobecker
2014-11-28 14:42 ` Joel Brobecker
2014-11-28 18:06 ` Joseph Myers [this message]
2014-11-28 20:50 ` Sergio Durigan Junior
2014-11-29 2:53 ` Joel Brobecker
2014-12-01 11:34 ` Pedro Alves
2014-12-07 14:21 ` Joel Brobecker
2014-12-08 6:05 ` Sergio Durigan Junior
2014-12-13 16:51 ` Joel Brobecker
2014-12-14 20:47 ` Joel Brobecker
2014-12-21 22:46 ` Joel Brobecker
2015-01-05 4:13 ` Joel Brobecker
2015-01-10 6:59 ` ANNOUNCEMENT: we have now switched to new git hooks (was: "Re: RFC: using AdaCore's git hooks for binutils-gdb.git ...") Joel Brobecker
2015-01-11 16:21 ` H.J. Lu
2015-01-12 4:08 ` Joel Brobecker
2015-01-12 4:16 ` Joel Brobecker
2015-01-12 18:03 ` Cary Coutant
2015-01-12 4:58 ` Joel Brobecker
2015-01-12 5:05 ` H.J. Lu
2015-01-12 6:56 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1411281801250.18562@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).