From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11200 invoked by alias); 28 Nov 2014 18:06:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11177 invoked by uid 89); 28 Nov 2014 18:06:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Nov 2014 18:06:21 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XuPvt-0000Qe-Dk from joseph_myers@mentor.com ; Fri, 28 Nov 2014 10:06:17 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.181.6; Fri, 28 Nov 2014 18:06:15 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1XuPvs-0005oi-52; Fri, 28 Nov 2014 18:06:16 +0000 Date: Fri, 28 Nov 2014 18:06:00 -0000 From: Joseph Myers To: "H.J. Lu" CC: Joel Brobecker , GDB , Binutils Subject: Re: RFC: using AdaCore's git hooks for binutils-gdb.git ... In-Reply-To: Message-ID: References: <20141128135756.GK548@adacore.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-11/txt/msg00718.txt.bz2 On Fri, 28 Nov 2014, H.J. Lu wrote: > Do we need to show the whole diff in the commit email? I think > a commit URL should be sufficient. Binutils-gdb commit > can have a very large commit diff due to generated files. For glibc we show the diff in the email to glibc-cvs, but *not* in the Bugzilla update (I'm not sure if the Bugzilla update works via sending emails to each bug whose number was extracted from the commit message, or by some other interface - but in any case, different messages are used for the two cases). Obviously you'd want to make sure that the patterns used to extract bug numbers are compatible with all those commonly used for binutils and GDB at present. In the early days of glibc git, sending the diff did result in at least one 500MB email to glibc-cvs when the hook decided some branch commit required the whole history (or at least the whole source tree) to be emailed out, but I haven't seen such problems lately. I don't know if binutils-gdb uses the whitespace checks that glibc does (but again, you'd probably want to be compatible with the existing logic). -- Joseph S. Myers joseph@codesourcery.com