From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id EDC173858003 for ; Fri, 17 Dec 2021 15:03:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EDC173858003 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x42e.google.com with SMTP id o13so4557916wrs.12 for ; Fri, 17 Dec 2021 07:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZWplDRruoFMvSD2F0cmko+ttshNllIHUzxPNsIhmzfk=; b=Gxp522xwuPC+BiaCmQrEkRSUqGvGB2pmKveQvK9eo245L4D0KUoHI4zewdtuZuMBr9 lESWehcfBXmQIbJaMFFw5DXDqOR4DnYeSuF0l2KYZINCYXv7dWpb/krsrCto+wRombzP Zyo4v9tMyuO6vhsjz7K41BY47G76D0F47UdSN7z0BpA6at5TKjxVEGRgqSvous+dd5WH CRvzZemBnUgIC5ut2PeeGVv2RYmJcThsnk3r4jozGa+jHGn+eISqTo6y+a7fa9lZXBT8 sWZ3y7ovET0qSi1fv1dmX1ZorV6dfACGvSDgG7Vp6CfbNN5dXuuZREFSwSAklRKAERVk 1FnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZWplDRruoFMvSD2F0cmko+ttshNllIHUzxPNsIhmzfk=; b=sMCYAl45OP8wGWSWGbJXKyS6cq9kNFlgyKplnmBnTj3wpCWyoqbGi6p2by520y4i2s JpPUOG+/XlmLEx2kLJq9IdDWjSbzJOB8z/pdWoIrj2cTdSgS0eTAnu11vjl+mAEQ56Nq 3OSrvaAMMr92mgSxl/TQaJf/sDPLa8Mwa/3GXtQcuzYKJcLPGSN2DLZXBJLtnqGzw4rO g8fl3OokXHqkEsXpbRcS/UZzSQeT3Gr1VaITxtQQ1Wky27Qa7vfg/0qbaWpXjtH+z/h2 QABGWmBrm56uvPEEAYQGF88k5sLuihhY8GJLwR7Zbo3Uy5QOfT56eDbm1hgVnzcBn3KD Dk0w== X-Gm-Message-State: AOAM530sHEPWBjqE3fT+TeuxCy9pJtkLhVjPYyF0tIujbbS93KOTtlz7 62PU+fMzT9wMr8Pu5iJJ8c4xHAD2MVnlhg== X-Google-Smtp-Source: ABdhPJwqDbJ8llTqVL8RO3Eq9L/AdcAeoHHQWmLEKTCLeQ/yMQ8vfHMaVXsba5FoCMPmL67qab9Qrw== X-Received: by 2002:adf:ef84:: with SMTP id d4mr2943490wro.175.1639753433134; Fri, 17 Dec 2021 07:03:53 -0800 (PST) Received: from tpp.orcam.me.uk (tpp.orcam.me.uk. [2001:8b0:154:0:ea6a:64ff:fe24:f2fc]) by smtp.gmail.com with ESMTPSA id l2sm530878wru.83.2021.12.17.07.03.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Dec 2021 07:03:52 -0800 (PST) Date: Fri, 17 Dec 2021 15:03:50 +0000 (GMT) From: "Maciej W. Rozycki" To: Andrew Burgess cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Initialize `m_ndimensions' in the member initializer list In-Reply-To: <20211215131813.GI175541@redhat.com> Message-ID: References: <20211215131813.GI175541@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 15:03:55 -0000 On Wed, 15 Dec 2021, Andrew Burgess wrote: > > Following our coding convention initialize the `m_ndimensions' member in > > the member initializer list rather than in the body of the constructor > > of the `fortran_array_walker' class. No functional change. > > --- > > gdb/f-array-walker.h | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > LGTM. Applied now, thanks for your review. Maciej