From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 09CF3385C41B for ; Sat, 8 Jan 2022 16:27:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09CF3385C41B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lf1-x12d.google.com with SMTP id i31so27357990lfv.10 for ; Sat, 08 Jan 2022 08:27:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=BkHRU0VJcdWK3F/hK6u2bBRTOBaxgfETpuPYLLlFCBg=; b=TvZv00xXlth2EA8JxsUlJ2V11d32Mi+9whLMVnXKyhfJPomSAZlsRE2wzy1hvheLXO NxglJ2/Ft6fCc5Hx3pIIpoYhfJ2A2mpBd+ioFjIPfiiljSlDimYacqTYGZpwAOqiCEb4 uFCEfVNuo1WpwYMAIqX4n98RMtJdxiiGrjctF6la4IoA4mT8XpHgZKNCnmet+HRpVjH/ cbzWRlChXOor8kZnJjHlXlYqpFbnfk9jqR1f5NnRD4K7QSN8+JqHndtDSSam8xFZGHjy Z81TEC196ktai156i2fH5fugeRlKiI6/TML1NZ8BkulVjl7TTy7r9uhZ2nlXZzOqq3P5 xJlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=BkHRU0VJcdWK3F/hK6u2bBRTOBaxgfETpuPYLLlFCBg=; b=Ntl9oryPUu7v75VhOM6aQAK9B0g7FvaKo+U0Fvf4IC3DTK+0RO+oeYVZ2njCWSp/1B bMnEHUsxRKZux2X2DF8nOEK+7A4N/sBrUi1c7t16Sp/j7cTAUJxgQekgNd6n0nJfrRTH dw7MZbBQhE5P7nDdEolFEMmzmFnhSZg0WEb1ZuYW7tdx/2O1ad5ysDy13pYAZvZo9ays GqHfA1Nf8hV6J9fOI/9rBK0hvhZg0lNaTjO+45ofuQa5fzj7as+u7VWeyhegU/BKB+83 MeYKa2y0zPdkIFOD7hBQyK1Lh2kejxJcr/rtf5hrshTA8YLXCE9kp6f+7bHwoMKIAwWu KtEg== X-Gm-Message-State: AOAM532u3wtZUPoRFeUNhxO3KTKJhlsYLfw2DT87T6RxEqnsSKielDI5 P+jHyOuL+yYB+MWmoWsbW0j7nQ== X-Google-Smtp-Source: ABdhPJySwZWwiGssa3wNs/3b4BszuWVmGxwa6WuVdIdyE8o/m+zDSwD3pj/w4a++m9fBXEcWqnEaaA== X-Received: by 2002:a05:6512:224a:: with SMTP id i10mr56122522lfu.13.1641659242923; Sat, 08 Jan 2022 08:27:22 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id be18sm282438ljb.114.2022.01.08.08.27.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Jan 2022 08:27:22 -0800 (PST) Date: Sat, 8 Jan 2022 16:27:20 +0000 (GMT) From: "Maciej W. Rozycki" To: Andrew Burgess cc: gdb-patches@sourceware.org Subject: Re: [PATCH 6/6] Add `set print array-indexes' tests for C/C++ arrays In-Reply-To: <20211215165100.GN175541@redhat.com> Message-ID: References: <20211215165100.GN175541@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jan 2022 16:27:25 -0000 On Wed, 15 Dec 2021, Andrew Burgess wrote: > > Add `set print array-indexes' tests for C/C++ arrays, complementing one > > for Fortran arrays. > > --- > > gdb/testsuite/gdb.base/array-indices.exp | 174 ++++++++++++++++++++++++++++++ > > gdb/testsuite/gdb.cp/array-indices.exp | 176 +++++++++++++++++++++++++++++++ > > If the previous C/C++ tests are combined then these would naturally be > combined too. Otherwise LGTM. Updated accordingly. Thank you for your review! Maciej