From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>,
Simon Sobisch <simonsobisch@web.de>
Subject: Re: [PATCH v3] gdb: split array and string limiting options
Date: Wed, 19 Jan 2022 22:18:11 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2201192204360.11348@tpp.orcam.me.uk> (raw)
In-Reply-To: <87lezif608.fsf@tromey.com>
On Fri, 14 Jan 2022, Tom Tromey wrote:
> Maciej> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Maciej> This commit splits the set/show print elements options into two. We
> Maciej> retain set/show print elements for controlling how many elements of an
> Maciej> array we print, but a new set/show print characters is added which is
> Maciej> used for controlling how many characters of a string are printed.
>
> Sorry, I missed that there had been a v2 and v3 when I was looking for
> unreviewed patches today.
No need for you to be sorry as far as I'm concerned, though I sympathise
as I know the feeling of the "D'oh!" moment.
> This version is ok. Thank you.
Thank you for your review, though Simon has raised a concern against v2
for a change, which I missed before as I wasn't directly cc-ed and which I
only came across today as I reviewed outstanding mailing list traffic:
<https://sourceware.org/pipermail/gdb-patches/2022-January/184855.html>.
I'm going to reply there then and wait for the outcome of the discussion
before I decide whether to push v3 as it is or whether we need v4.
Maciej
prev parent reply other threads:[~2022-01-19 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 23:13 Maciej W. Rozycki
2022-01-14 19:53 ` Tom Tromey
2022-01-19 22:18 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2201192204360.11348@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simonsobisch@web.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).