From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 47F4E386549C for ; Wed, 30 Mar 2022 10:24:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 47F4E386549C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x431.google.com with SMTP id u16so28582429wru.4 for ; Wed, 30 Mar 2022 03:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=Lxc2FHImhbPTaMZ828Dqu8lZtjXkQ5WMVdRxpMt7gU0=; b=MtPza0sIYFCv9VcKZkC3jzv5q4St6J2aWQxDYXIZmrYUAid6J4hyjKLBZPcocmENzr KDh8iJIEm7QHAIZhUptIkQCcsJQgivDc2PbChLPWJLNnDijAW1NX/JyhZdxor9/cdTcz /N9G6LDVteeEqa//aTcBUKZKi2ctFtdzzL6QcMFGee2QA4ijcrY6Hen2MvaDvfB29Age qloxhIzPbjcjH1t2WB+NrJQfig/1zf06WAd/Eb7tN83wcN/N+C8/laPNNvRsXdfW/dgV vpSwoIf9zw9GghnhE5kR9r0Q55QwDKBIg1FlhxbG2ijQrRN/aK1BZYzmSBMhrB0iNfMR GfxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=Lxc2FHImhbPTaMZ828Dqu8lZtjXkQ5WMVdRxpMt7gU0=; b=J/JoAgzYms5zjGLp43zagdmYtWSZyhLi1lfdiLQZBtXNRyB4rAE03w+FUQUERqOlz0 XMkJOyEKRzIQGVffKjW8IDSra9dqC953DeRlWQ3Ob2e3II2Plb8LeUwq7KpW8Qz1RzxX sDtV99Ij+aT+V+bYIvNaUYBfL8a8Bpi/BuQNTrXMNKtD3V1DoZMnCu71t6dQEITUCzfS 60aa/jh2ljSfJrCjAl5rhW8bUrUxuQ/TMCt66w4LU2ykBgmOOCinOaqet9cjGhZe6QpG OSLA7r8Rl8T4+FS2Nw386X1kmCMShbFOvv6zKe8WLEqfeEl+5ozojo01u3c7yUDxd8AB 00BA== X-Gm-Message-State: AOAM532N66X0K5xmDeL51X84hEc+gomBepd2ARndJJlHhLOEznNDqMx1 iAagXm6W3kDmZz4N+BIYFEEmN97awxIXkA== X-Google-Smtp-Source: ABdhPJyR40W5e9dDeKaF0mfTQtpJhgbzSp4IDuuVshdDHE/2haZSKtBkBXkKjvp9ecZrRVIbGpY3Og== X-Received: by 2002:a05:6000:1541:b0:205:ce62:52fa with SMTP id 1-20020a056000154100b00205ce6252famr10628444wry.282.1648635855123; Wed, 30 Mar 2022 03:24:15 -0700 (PDT) Received: from [192.168.0.201] ([212.69.42.53]) by smtp.gmail.com with ESMTPSA id k40-20020a05600c1ca800b0038c6c8b7fa8sm4470191wms.25.2022.03.30.03.24.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2022 03:24:14 -0700 (PDT) Date: Wed, 30 Mar 2022 11:24:14 +0100 (BST) From: "Maciej W. Rozycki" To: gdb-patches@sourceware.org cc: Andrew Burgess , Simon Marchi , Tom Tromey , Simon Sobisch Subject: [PATCH v5 4/8] GDB/testsuite: Tighten `set print elements' error check In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:24:17 -0000 Match the whole error message expected to be given rather than omitting the part about the "unlimited" keyword. There's no point in omitting the missing part first, and second with an upcoming change the part in parentheses will no longer be a fixed string, so doing a full match will ensure the algorithm correctly builds the message expected here. Also avoid any wildcard matches. --- No change from v4. New change in v4. --- gdb/testsuite/gdb.base/default.exp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) gdb-test-set-print-elements-tightening.diff Index: src/gdb/testsuite/gdb.base/default.exp =================================================================== --- src.orig/gdb/testsuite/gdb.base/default.exp +++ src/gdb/testsuite/gdb.base/default.exp @@ -525,7 +525,8 @@ gdb_test_no_output "set print asm-demang #test set print demangle gdb_test_no_output "set print demangle" "set print demangle" #test set print elements -gdb_test "set print elements" "Argument required .integer to set it to.*" +gdb_test "set print elements" \ + "Argument required \\(integer to set it to, or \"unlimited\"\\)\\." #test set print object gdb_test_no_output "set print object" "set print object" #test set print pretty