From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 3F6FB3858405 for ; Wed, 30 Mar 2022 10:58:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F6FB3858405 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x429.google.com with SMTP id m30so28729440wrb.1 for ; Wed, 30 Mar 2022 03:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=8YH3tVo/yFH38/ZsUPUAtKz+Mv5udZKChiwDcNlG3Sc=; b=TtM5UsHikkktvJe9hjTyikcSN6oDwWVf62awFzrPNZ8GGkf+TH9Z5iRPVpOzO0COdV rMMpljS0eESuPXEsqnhGJcZrRy8IstFpf0osyD5BM/MxVmT35Kx8bv1fo4xn+Fu3gg6J 50adfJ8ljzyKGA6vWeBnEbplnxRHo9Gi2rK5yp/Aw+vAyOLv34IUxUKt9ypA8FQbTbrC wXvgXvdqAbDYxas7zQaT/865+pLh61pTi8BFl58vJ8Ka6S5dqUsOsZbRCoD6+xd2A4XU FpWtcJtxOXd8VGIDrKF2drMgp/9gZsvz77ztYhr6NMwi52YCBl+PrLrsacgDgvhZSiFV TEFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=8YH3tVo/yFH38/ZsUPUAtKz+Mv5udZKChiwDcNlG3Sc=; b=AQUiINI979VeDj+XyDDw6IRPawUdJ+SFTLRe55BkeuqNPawT+isbfqCI8Q1WrQBjFK 46b4ZFNFR4kQptBoRcKEahPBUbZ4fB7DaWKRMxtUznCI6F8P7pG43S/D/eOP5Xubn5Ym dvZC3z0ESYuiTTUpBHpPfn3E+SD+NCyfodGNUUp6fhhND80h20WyqJscdgucdes1lvl8 RMWsBmx6koIUoXSXLCMH4IdG0mMVE8ihq93OfdLg3IUAjp1e9+wzXWf4xgEkQO4UyRQE YE43yhicWImAoD+pGMIJYb510YfsYuzvk5e9NxC8kkhY43/X+JMdGBN7vRSKUP9TQkfx tlnw== X-Gm-Message-State: AOAM531uovFTDDmRRePN+UuD1IuapBPVnnsPQ7ni1ukgtlHwOmz7UxQr TLXnvxWSbQTxpdORr+brBNTvEw== X-Google-Smtp-Source: ABdhPJzKe/LV9do+Ur8XESJmtfA2Ad03elkFh4hvLOvzY+NyDMhGuHE5mdts2F2DjTCquv4wOAuljw== X-Received: by 2002:a5d:6489:0:b0:203:d75b:5d05 with SMTP id o9-20020a5d6489000000b00203d75b5d05mr35260096wri.236.1648637934082; Wed, 30 Mar 2022 03:58:54 -0700 (PDT) Received: from [192.168.0.201] ([212.69.42.53]) by smtp.gmail.com with ESMTPSA id p14-20020a05600c1d8e00b0038dbb5ecc8asm3892819wms.2.2022.03.30.03.58.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2022 03:58:53 -0700 (PDT) Date: Wed, 30 Mar 2022 11:58:51 +0100 (BST) From: "Maciej W. Rozycki" To: Simon Sobisch cc: gdb-patches@sourceware.org, Andrew Burgess , Simon Marchi , Tom Tromey Subject: Re: [PATCH v5 6/8] GDB: Allow arbitrary keywords in integer set commands In-Reply-To: <31c7d89e-b786-02ef-6524-0f3bea04e994@web.de> Message-ID: References: <31c7d89e-b786-02ef-6524-0f3bea04e994@web.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:58:56 -0000 On Wed, 30 Mar 2022, Simon Sobisch wrote: > > Rather than just `unlimited' allow the integer set commands (or command > > options) to define arbitrary keywords for the user to use, removing > > hardcoded arrangements for the `unlimited' keyword. > > > > Make obsolete the confusingly named `var_zinteger', `var_zuinteger' and > > `var_zuinteger_unlimited' `set'/`show' command variable types redefining > > them in terms of `var_uinteger', `var_integer' and `var_pinteger', which > > have the range of [0;UINT_MAX], [INT_MIN;INT_MAX], and [0;INT_MAX] each. > > Those "confusingly named" parts go into python, too; maybe someone could > create a follow-up patch or adjust this one. > I think keeping them aligned is very useful (if renamed the old python > names should stay as aliases for the new ones, and ideally the doc > should reference a "until GDB 12: named ..." entry as this helps a lot > when creating python extensions). I can't think of user-visible Python syntax for such a redefinition, and my lack of knowledge of the language does not help either, so someone more experienced in this area would have to step in. It would be great to have the ability to add arbitrary keywords from Python code too I suppose. And the old keywords have to stay anyway, just as I have retained, e.g. `add_setshow_zuinteger_unlimited_cmd' in C++ code so that callers do not have to repeat an explicit reference to `zuinteger_unlimited_literals'. Maciej