From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id A0CD63858D3C for ; Thu, 26 May 2022 14:24:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0CD63858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lj1-x22e.google.com with SMTP id s20so1913047ljd.10 for ; Thu, 26 May 2022 07:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=t6fJC8Xvns1fR064bmb8o8hfBBIdKUjBeq0ZPLWlDts=; b=gpwz4L8Qm0gwBwtKI8kNS8pUxOBXmqIBWWHqg1htWepcdc7slB3Nf5dum0CNFLoFt8 /lXvVl6cPq735TiPazf6XZN/tXbUVZfi/SOCjuc3AVHjq4QCkrf/znSrm8OkYFa8FcjZ DOAy4MeBIjYI8jl1PgAEzEppb1Ys5J549jgMTCDoYXKCmoyeK407y5myXF9I34UO+k2C 8MWXlMf8+aJdaZWRDO936BfafUeUV87/fUWZYPztt+TgHpcTv14pLzDWENHZHngItRJT dUAYlgBo1TK/7xhfDzrNQXu5HklsqnYvLaC/F+j4hEkz7+Pc/QFfVBgPbYY22p0hVc+A GR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=t6fJC8Xvns1fR064bmb8o8hfBBIdKUjBeq0ZPLWlDts=; b=ZOEbX1A9JVZj6hrLo42ZqUssp+04tOZpl4piX1yYowMCG4nj/zVROXSBBBCA/D0yRb M16dcPXeyKvHL0WC8+Kye5kV+h/hNN5jxTybWYSFGtS61dpgLdhxY7oJsdqYudTl7ZY2 lvuTYqPEPAsGRLPY2QkOxfl5Fu24o9ZBZGYW5nGfy9F0YunbAvd7w/UHKInygsP7/1tY SPwAWJci5GkdiiZzIS0FKAQlrcXrS082gjt+bBv3VjcPZALuCDZRpA6Fyi8/oq/5aeGX HHg5dhndAoakeu9U7shxKJAd+8FA7Gz78IWBKOafACtB83JAb7aOB0MVFG51etWGj3Gn 0aag== X-Gm-Message-State: AOAM530Oza5TFHiXUXuT7PWB9giH7Xkrv/JDPOAlmyGi1C6xK3VsQGmA FNt0Mx4mymu2bPVmzIjtTAbePdaZwUmohA== X-Google-Smtp-Source: ABdhPJyavKP+rEc6HzBldu0O6RhNpB+xV71IIzRG6MSjTqXmo5+A2xukoLFPETAjXiZrbaGWVPyaTQ== X-Received: by 2002:a2e:6808:0:b0:253:cf8a:f127 with SMTP id c8-20020a2e6808000000b00253cf8af127mr21389772lja.62.1653575046288; Thu, 26 May 2022 07:24:06 -0700 (PDT) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id y29-20020a0565123f1d00b00478ad871b25sm379680lfa.145.2022.05.26.07.24.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 May 2022 07:24:05 -0700 (PDT) Date: Thu, 26 May 2022 15:24:03 +0100 (BST) From: "Maciej W. Rozycki" To: Bruno Larsen cc: gdb-patches@sourceware.org, Simon Sobisch , Tom Tromey , Andrew Burgess Subject: Re: [PATCH v5 3/8] GDB: Add `NUMBER' completion to `set' integer commands In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 14:24:09 -0000 Hi Bruno, > > This just follows the existing logic in `parse_option' and is really a > > special case. I am inconvinced that there is a benefit from getting the > > completion broken visibly to the user for the sake of avoiding a manual > > call in the code. Sorry. > > I don't really think `complete set print elements N` would naturally > occur, so I don't really think it would break completion from a user > standpoint. However, I think we can agree to disagree here, since you do away > with this function later on, and I'm fine with how you decided to work on that > patch. If someone, pehaps mistakenly, enters `set print elements N`, then the last word will complete to `NUMBER' (and likewise with `complete set print elements N'), which does not correspond to the syntax supported and is therefore supposed not to happen. Maciej