From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id D463B384D1AC for ; Wed, 29 Jun 2022 14:29:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D463B384D1AC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x32b.google.com with SMTP id g39-20020a05600c4ca700b003a03ac7d540so8858385wmp.3 for ; Wed, 29 Jun 2022 07:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=GudaypKbKRFsSqmaus92z+pmEtDe/6eTiDTgasIjEvM=; b=M+yPNulPEbIkQfczsVqSbzvGsy0f7iJwQBePkhR9JDip0aWYZyDcemjb3Z2i6u8g1B l4MvnEzYcxXERo9Qf/vMOMhbeQjnB50Su9WDRRjtJwBPpHv1WnEE80NDumKkWpfQnkuq QbT/9dUr5XdDTwxZQ67bhGiItPokOMEZqx1AgmgfGHdeu+fj6gFHOwY2fFDHwS9hvICM aEOowRTa1NErSfpCxdApx2uVhXD0Oyhx27B2TtNwXxLnHTG5lZMpbmfXlBkZ7NLdFoU5 R3uHGzYWO7op3igAe2IVGZQ+tHHaePxmA6G76GvGBkW0FvON5Uy8ynbTHWBRnK45IacH dWrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=GudaypKbKRFsSqmaus92z+pmEtDe/6eTiDTgasIjEvM=; b=AvBhTjDu+bua6PGxVFXFNkus0rl/n1Fil7zDRzIf1eYrbBaG3vkW5VkcDQlHf/LrgS zChCXjgdBZ29eltJtZmHtMHulFb4u84ZZO7zsgRq5s1qmQsZpIoKa+QkaooXEkSS8Z7A pt+uL+iIYWzSNnFJBZyVCI0eUdxtK4UxOXnklG17m3LKZ1PGib6zoljPRjlIpChjHuwK AEpD8sqOY9uFjAZqSY/WdZx1ZlwIvUMWt/ABFjDnZ+PUHAS1q22eKaExznSbq3BDNSsz PKMw3/d7we47iYkqan5bVwug5XHl3hxTg26wnI7qszfUcCGbNsf4L3q+Rv53/Y3mxoIl Lz6w== X-Gm-Message-State: AJIora+xHzPXzyd5e33PzIF2sGr522iK59CAuhN7EWTusWmxQFdsP2kJ pbLJXzKF3tAFqrr/QWaaRq8d4w== X-Google-Smtp-Source: AGRyM1vfz1E0nXdANSXJoKb2i0dK0cm8VBo5CrAgrUxZFRJH2kgClgCvp26vsLrK4wlgI5Yv1pJ3nA== X-Received: by 2002:a1c:2b05:0:b0:3a0:2ae2:5277 with SMTP id r5-20020a1c2b05000000b003a02ae25277mr4177443wmr.30.1656512966694; Wed, 29 Jun 2022 07:29:26 -0700 (PDT) Received: from tpp.orcam.me.uk (tpp.orcam.me.uk. [2001:8b0:154:0:ea6a:64ff:fe24:f2fc]) by smtp.gmail.com with ESMTPSA id m9-20020a056000024900b0020c5253d907sm500360wrz.83.2022.06.29.07.29.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2022 07:29:26 -0700 (PDT) Date: Wed, 29 Jun 2022 15:29:25 +0100 (BST) From: "Maciej W. Rozycki" To: Andrew Burgess cc: gdb-patches@sourceware.org, Simon Sobisch , Tom Tromey Subject: Re: [PATCH v5 4/8] GDB/testsuite: Tighten `set print elements' error check In-Reply-To: <871qveayj5.fsf@redhat.com> Message-ID: References: <871qveayj5.fsf@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 14:29:29 -0000 On Fri, 24 Jun 2022, Andrew Burgess wrote: > > Match the whole error message expected to be given rather than omitting > > the part about the "unlimited" keyword. There's no point in omitting > > the missing part first, and second with an upcoming change the part in > > parentheses will no longer be a fixed string, so doing a full match will > > ensure the algorithm correctly builds the message expected here. Also > > avoid any wildcard matches. > > LGTM. I have committed this change too, thank you! Maciej