From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>,
Tom Tromey <tom@tromey.com>, Simon Sobisch <simonsobisch@web.de>
Subject: Re: [PATCH v6 1/8] GDB/Guile: Don't assert that an integer value is boolean
Date: Fri, 21 Oct 2022 08:58:28 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.20.2210181602210.19931@tpp.orcam.me.uk> (raw)
In-Reply-To: <a7c76c91-91c8-61f3-d2e2-b6258820f698@polymtl.ca>
On Mon, 17 Oct 2022, Simon Marchi wrote:
> > @@ -742,7 +742,7 @@ pascm_set_param_value_x (param_smob *p_s
> > if (var.type () == var_uinteger
> > || var.type () == var_zuinteger_unlimited)
> > {
> > - SCM_ASSERT_TYPE (gdbscm_is_bool (value)
> > + SCM_ASSERT_TYPE (scm_is_integer (value)
>
> Was this just a brainfart when the code was initially written?
Based on the switch cases immediately above it looks like a copy-&-paste
or a repeated-pattern mistake to me.
> > @@ -206,3 +380,5 @@ with_test_prefix "previously-ambiguous"
> > gdb_test "help set print s" "This command is not documented." "set help"
> > gdb_test "help set print" "set print s -- This command is not documented.*" "general help"
> > }
> > +
> > +rename scm_param_test_maybe_no_output ""
>
> Just wondering, what is the intention here, to avoid polluting the
> global namespace? If so, I appreciate the intention, but given we don't
> do that in thousands of other tests, I'm not sure if it's really useful.
Yep, just cleaning up after oneself. I think the knowledge of the more
obscure TCL features is not so great among people as to expect everyone to
know this can be done in the first place.
> Anyhow, this patch LGTM:
>
> Approved-By: Simon Marchi <simon.marchi@polymtl.ca>
Applied now, thank you for your review.
Maciej
next prev parent reply other threads:[~2022-10-21 7:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 22:03 [PATCH v6 0/8] gdb: split array and string limiting options Maciej W. Rozycki
2022-08-17 22:03 ` [PATCH v6 1/8] GDB/Guile: Don't assert that an integer value is boolean Maciej W. Rozycki
2022-10-17 13:43 ` Simon Marchi
2022-10-21 7:58 ` Maciej W. Rozycki [this message]
2022-10-21 18:44 ` Simon Marchi
2022-10-21 20:54 ` Maciej W. Rozycki
2022-10-22 0:48 ` Simon Marchi
2022-08-17 22:03 ` [PATCH v6 2/8] GDB/doc: Document the Guile `#:unlimited' keyword Maciej W. Rozycki
2022-08-18 6:06 ` Eli Zaretskii
2022-09-01 10:31 ` Maciej W. Rozycki
2022-08-17 22:04 ` [PATCH v6 3/8] GDB/testsuite: Expand Python integer parameter coverage across all types Maciej W. Rozycki
2022-10-17 13:56 ` Simon Marchi
2022-10-21 7:59 ` Maciej W. Rozycki
2022-08-17 22:04 ` [PATCH v6 4/8] GDB/Python: Make `None' stand for `unlimited' in setting integer parameters Maciej W. Rozycki
2022-10-17 14:26 ` Simon Marchi
2022-10-21 8:03 ` Maciej W. Rozycki
2022-08-17 22:04 ` [PATCH v6 5/8] GDB/Python: Use None for `var_zuinteger_unlimited' value set to `unlimited' Maciej W. Rozycki
2022-08-18 6:08 ` Eli Zaretskii
2022-10-17 15:02 ` Simon Marchi
2022-10-29 15:58 ` Maciej W. Rozycki
2022-10-31 13:00 ` Simon Marchi
2022-10-31 13:31 ` Maciej W. Rozycki
2022-11-01 12:28 ` Maciej W. Rozycki
2022-10-26 11:58 ` Luis Machado
2022-10-29 13:52 ` Maciej W. Rozycki
2022-10-31 8:14 ` Luis Machado
2022-10-31 12:37 ` Luis Machado
2022-10-31 13:08 ` Maciej W. Rozycki
2022-10-31 13:14 ` Luis Machado
2022-10-31 14:05 ` Maciej W. Rozycki
2022-08-17 22:04 ` [PATCH v6 6/8] GDB: Allow arbitrary keywords in integer set commands Maciej W. Rozycki
2022-08-17 22:05 ` [PATCH v6 7/8] GDB: Add a character string limiting option Maciej W. Rozycki
2022-08-17 22:05 ` [PATCH v6 8/8] GDB/testsuite: Expand for character string limiting options Maciej W. Rozycki
2022-08-18 0:07 ` [PATCH v6.1 " Maciej W. Rozycki
2022-09-01 10:32 ` [PING][PATCH v6 0/8] gdb: split array and " Maciej W. Rozycki
2022-09-08 9:37 ` [PING^2][PATCH " Maciej W. Rozycki
2022-09-14 17:43 ` [PING^3][PATCH " Maciej W. Rozycki
2022-09-22 22:07 ` [PING^4][PATCH " Maciej W. Rozycki
2022-09-29 7:09 ` [PING^5][PATCH " Maciej W. Rozycki
2022-09-29 7:12 ` Simon Sobisch
2022-10-06 15:46 ` [PING^6][PATCH " Maciej W. Rozycki
2022-10-12 21:19 ` [PING^7][PATCH " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2210181602210.19931@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=simonsobisch@web.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).