From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id B5C2E385AC2C for ; Fri, 21 Oct 2022 07:58:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5C2E385AC2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lf1-x132.google.com with SMTP id bp15so3679759lfb.13 for ; Fri, 21 Oct 2022 00:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x6vInwtNlKtDWM1zHwB7Hh1Dc0R54ct6cH+nvHB+miI=; b=Gv3vwPaB69uppOfpKn3S2yGjnycaSz525FrPGDKOcDeBCtjEW8c/6n8Yj/eHF3E1PW oQi7qTlbDTBc9x/+TUW5VJ1I5cntvXWzowNs1cz8ucgBfLCsdqQSReu51YbmwjTDdigD Y2bWJVG85cKnF6yWWJ6lG7Aa152GSS1q59bqq6NWX6qpnByz6QHn0hrzOR6DG60JPR43 bCqW4VHwoC4uFVEj+lGLyNx1PHEBC7CumjE609T397S35wt9bB/UR/DJe5oq3lCIcm5O PFs3lJnnIVHemG2IhQmCEnyRzuw4hbjcBKYANDVU8c2CW5ZfrjT5nKxkOjODSI40mYnT MkrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x6vInwtNlKtDWM1zHwB7Hh1Dc0R54ct6cH+nvHB+miI=; b=h49pi4HP6xWNsXDANrKN+2VEJTmhTh1MscnM+HyCxN3ewkeMvubCpp1NycPF5eCJqn BygwysSDPlxNwfYpz3YIBkiwJ59NdLhCAgn/KZ/0CFgI8kXAz3zwBiqWS2AQ/b8ALGh1 NQsrB39dUVLutNHSeVS0wqz/+vmGJyb5XgFsQ9L3tF6de2B9LkUtOUgFFww86mP3x8lx zAVVvVwKHYrFsnt4zC9oQkaOtC2rXDaMcXmOYGheL84XRACPxZaKCzwYANuNQWrB694U L2VcFfPXkuQlt4GWr7Us/2FHWiTrX39MX4sn7qhp/PkiikVIKXS2Gr6JlYUbZWmUVxKe WUrA== X-Gm-Message-State: ACrzQf3uX31X1GqJVWvzJxRVViVqnVSTQD5hbC0Ix6y1I5Gd02xCyIs3 dEmaaxN3f1M31WdxkFAtODUk5w== X-Google-Smtp-Source: AMsMyM7eyAD6bD5vsrokQ10zlYxopsKPHzPR3s2iZMWw/qgeB8PM2Wtr0zsuui1R1rek4fsyv99jGw== X-Received: by 2002:ac2:50da:0:b0:4a2:44dc:b719 with SMTP id h26-20020ac250da000000b004a244dcb719mr6005718lfm.652.1666339112259; Fri, 21 Oct 2022 00:58:32 -0700 (PDT) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id a5-20020ac25e65000000b004a054535826sm3078203lfr.24.2022.10.21.00.58.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Oct 2022 00:58:31 -0700 (PDT) Date: Fri, 21 Oct 2022 08:58:28 +0100 (BST) From: "Maciej W. Rozycki" To: Simon Marchi cc: gdb-patches@sourceware.org, Andrew Burgess , Tom Tromey , Simon Sobisch Subject: Re: [PATCH v6 1/8] GDB/Guile: Don't assert that an integer value is boolean In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 07:58:35 -0000 On Mon, 17 Oct 2022, Simon Marchi wrote: > > @@ -742,7 +742,7 @@ pascm_set_param_value_x (param_smob *p_s > > if (var.type () == var_uinteger > > || var.type () == var_zuinteger_unlimited) > > { > > - SCM_ASSERT_TYPE (gdbscm_is_bool (value) > > + SCM_ASSERT_TYPE (scm_is_integer (value) > > Was this just a brainfart when the code was initially written? Based on the switch cases immediately above it looks like a copy-&-paste or a repeated-pattern mistake to me. > > @@ -206,3 +380,5 @@ with_test_prefix "previously-ambiguous" > > gdb_test "help set print s" "This command is not documented." "set help" > > gdb_test "help set print" "set print s -- This command is not documented.*" "general help" > > } > > + > > +rename scm_param_test_maybe_no_output "" > > Just wondering, what is the intention here, to avoid polluting the > global namespace? If so, I appreciate the intention, but given we don't > do that in thousands of other tests, I'm not sure if it's really useful. Yep, just cleaning up after oneself. I think the knowledge of the more obscure TCL features is not so great among people as to expect everyone to know this can be done in the first place. > Anyhow, this patch LGTM: > > Approved-By: Simon Marchi Applied now, thank you for your review. Maciej