From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id EB7AD385AC30 for ; Fri, 21 Oct 2022 07:59:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB7AD385AC30 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lj1-x234.google.com with SMTP id a6so2638335ljq.5 for ; Fri, 21 Oct 2022 00:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IS9LtvjH7FIJ9/9vfZV1HmLPDPtq+mjCWZxwurLFTNo=; b=JPl0XExtiFj4v48f+H4ExVvTHvIumXJbLT0MKKPZb16+oBy7FPKj4eGXtBhYV3h8um wwXbGcY21ebWxtkyMq4pyVD6u81CEwimTW5xF11bBbDmdGgofFLGgvB8H/yo2ljgQSnK FrPxKbsseadc+Ea3bxuo03FRfCn3rKbF+cMf10vPyYug0HMyFcq67VtKPDIZyO08PquT LFMaZ9sZyx4MfxcBTfzIIcNwwyQJzto9NHC+Ek1Sed8gMi7Ae38n2pTOCRMMFWQGqQYN VlIPJkz5mj4uAuCruTEthjbePfJm4bNtDh6L7h+iZyn1q10FrceOrnr8LkdhJI26BxLq Xefw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IS9LtvjH7FIJ9/9vfZV1HmLPDPtq+mjCWZxwurLFTNo=; b=d4P4q6jxouo7kjggmRE1WVoAzhyh0Dq2h4BQCdfNr72hCmD3nB3I5bt5sYJeOx9EwR n9ISR4Z2/G+a2nXmzLBSX4aCd0rtW74NVtvZlDvnR3uVVlfs/BMrgILsXcX/BZQ2K06f OruBuFve2Moy7Ze1/CAkj7nRlum1mLZYTfVQ5QTHaZet5U5fvo1wGDEoeKmsJjzqEeis lrs4Qg0D6jenOtx2x6Y2uJLLG3efYwzuK/jCQuQu/1TGVX0X+ZTumHGCkf34JXMZUlln ZT3WGd0u+0o6bf9yXc89BtfywPQUGYI8wJbMGo4pCLqtEJ2CuasP34Z9SO/5BRiUW4UM 1HRA== X-Gm-Message-State: ACrzQf2v7pJmumGBaDEvAWD+iIXnUJ8sCet/wnxb6fQERgPA54smWfNn 2zDB1DzV/ooWzBjGwc8YJXkGXKE6A/bQdzoq X-Google-Smtp-Source: AMsMyM47dou70IGatjkogi5F+NOvikithufqniDyhmQ5GniYMm4n2gctB1BLkHCi+1EJtF6qhJkVXw== X-Received: by 2002:a2e:a884:0:b0:25d:ea06:6a3f with SMTP id m4-20020a2ea884000000b0025dea066a3fmr6034212ljq.335.1666339172462; Fri, 21 Oct 2022 00:59:32 -0700 (PDT) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id i19-20020a2ea233000000b0026c603169aesm3295573ljm.0.2022.10.21.00.59.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Oct 2022 00:59:31 -0700 (PDT) Date: Fri, 21 Oct 2022 08:59:29 +0100 (BST) From: "Maciej W. Rozycki" To: Simon Marchi cc: gdb-patches@sourceware.org, Andrew Burgess , Tom Tromey , Simon Sobisch Subject: Re: [PATCH v6 3/8] GDB/testsuite: Expand Python integer parameter coverage across all types In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 07:59:35 -0000 On Mon, 17 Oct 2022, Simon Marchi wrote: > > Also verify PARAM_UINTEGER, PARAM_INTEGER, and PARAM_ZINTEGER parameter > > types, in addition to PARAM_ZUINTEGER and PARAM_ZUINTEGER_UNLIMITED > > already covered, and verify a choice of existing GDB parameters. Add > > verification for reading parameters via `.value' in addition > > to `gdb.parameter('')' as this covers different code paths. > > Thanks: > > Approved-By: Simon Marchi I have pushed this change now, thank you for your review. Maciej