From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 1108438CEFE6 for ; Fri, 21 Oct 2022 20:54:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1108438CEFE6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lf1-x131.google.com with SMTP id b2so7210240lfp.6 for ; Fri, 21 Oct 2022 13:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2tvzHtpEyCFdKBJLGt6QJeG9xGlzQ8GNDn5awe4Bw9o=; b=HKhDYZDaoaIVC79snOeoObchtOtIMjzLgC4oL8KZBSBhhP7wS4yUEs/tCNaVGdnzlA sTZ0rVyUgKmVljnpSKKtuwtQ8wngj+LHY9FaxO04Uh44Jm+pR3SX2bLDYNtpl1VTXF6R Z/e4UKSmfPx/TXjM2QC+MuBKwK9+4PuRrHSeoD+W/fZ4iNgtKVPUdTKTpWaDpe0wl0v+ I5jVksGr7kRs/ihthQ5OLseCROhKRJewmqVuy6orhhzHlDKY4Rtgzx6UKmxi+2s78ddf df3ZX102zlisAF2vtw1jbIjMW/onYidMXmBfE5qOOMmSsy6u8wT9rNA92ErHu7D4M2L1 wMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2tvzHtpEyCFdKBJLGt6QJeG9xGlzQ8GNDn5awe4Bw9o=; b=5F6s7im+WrM50DIFDrM1FLbEVEq1e6Y0/YF96n4iPo/y2RVAx0N/0tnHeycEr1a3l9 k0rmTuCwbiyEgJ6cZVM0AAUbvhO+ijXU6gS8T7+TUDM1bA7AVxP0mBpALwmsTecyhlo4 HL3HYfvX580/8nyvy/i4U33/mkYBYq/ZCSBASkR/g721Hwe96Qza8dJs3NIbl7iVXy2d Q1Fb7VTlvKAk5v839IngHCXYsZAnxtduWJRWFr3AkgdTeEhDJ89clmRmLbkZIEO305j1 rvI3+FXAzPUvzIOZDTYxaAqJhojzR8vG7PqvBJBiSWtru9T4Nq0omhFGJvnDsjDEfE6w hH1w== X-Gm-Message-State: ACrzQf2fHgAe5vpWL3d7whylM9ix8XnajwjUP9Ob3j21uGkYdMKG7AEF mMUYOkr2DlOhJzqIL+vSPTHSwQ== X-Google-Smtp-Source: AMsMyM47M471bmxQGwFSlRgQga5XG7t8iQXEZUj+5dR4MPs72Ml8PTpYL30L5UIXB7FsY1xewYiuEw== X-Received: by 2002:ac2:539c:0:b0:4a2:259c:c849 with SMTP id g28-20020ac2539c000000b004a2259cc849mr7579448lfh.323.1666385651336; Fri, 21 Oct 2022 13:54:11 -0700 (PDT) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id bj11-20020a2eaa8b000000b0026a92616cd2sm3563057ljb.35.2022.10.21.13.54.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Oct 2022 13:54:10 -0700 (PDT) Date: Fri, 21 Oct 2022 21:54:07 +0100 (BST) From: "Maciej W. Rozycki" To: Simon Marchi cc: gdb-patches@sourceware.org, Andrew Burgess , Tom Tromey , Simon Sobisch Subject: Re: [PATCH v6 1/8] GDB/Guile: Don't assert that an integer value is boolean In-Reply-To: <1962a74c-690c-518e-0bfb-1d9fa2876847@polymtl.ca> Message-ID: References: <1962a74c-690c-518e-0bfb-1d9fa2876847@polymtl.ca> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 20:54:37 -0000 On Fri, 21 Oct 2022, Simon Marchi wrote: > Hmm, I see this failure now: > > guile (set-parameter-value! test-PARAM_ZINTEGER-param #:unlimited)^M > ERROR: In procedure set-parameter-value!:^M > In procedure gdbscm_set_parameter_value_x: Wrong type argument in position 2 (expecting integer): #:unlimited^M > Error while executing Scheme code.^M > (gdb) FAIL: gdb.guile/scm-parameter.exp: kind=PARAM_ZINTEGER: test-PARAM_ZINTEGER-param: guile (set-parameter-value! test-PARAM_ZINTEGER-param #:unlimited) > > This is with Guile 3.0, if that matters. It's not a failure, the "ERROR: ..." message, perhaps confusingly, comes from GDB under test rather than the DejaGNU test harness and therefore it doesn't score as a test error or count towards test results. The context is: (gdb) PASS: gdb.guile/scm-parameter.exp: kind=PARAM_ZINTEGER: test-PARAM_ZINTEGER-param: PARAM_ZINTEGER parameter value (2) guile (set-parameter-value! test-PARAM_ZINTEGER-param #:unlimited) ERROR: In procedure set-parameter-value!: ERROR: In procedure gdbscm_set_parameter_value_x: Wrong type argument in position 2 (expecting integer): #:unlimited Error while executing Scheme code. (gdb) PASS: gdb.guile/scm-parameter.exp: kind=PARAM_ZINTEGER: test-PARAM_ZINTEGER-param: guile (set-parameter-value! test-PARAM_ZINTEGER-param #:unlimited) and the test case requires that message to be there to pass: set param_integer_error \ "ERROR: In procedure set-parameter-value!:\r\nERROR: In procedure\ gdbscm_set_parameter_value_x: Wrong type argument in position 2\ \\(expecting integer\\): #:unlimited\r\nError while executing Scheme\ code\\." so there's nothing to worry about. In other words the test case verifies that a particular error message is printed by GDB when supplied with a bogus command. Thanks for your meticulousness though! Maciej