public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Luis Machado <luis.machado@arm.com>
Cc: gdb-patches@sourceware.org, Simon Sobisch <simonsobisch@web.de>,
	 Tom Tromey <tom@tromey.com>,
	Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v6 5/8] GDB/Python: Use None for `var_zuinteger_unlimited' value set to `unlimited'
Date: Mon, 31 Oct 2022 13:08:57 +0000 (GMT)	[thread overview]
Message-ID: <alpine.DEB.2.20.2210311248540.19931@tpp.orcam.me.uk> (raw)
In-Reply-To: <d8516652-ddac-6241-8b94-6e32147bbcab@arm.com>

On Mon, 31 Oct 2022, Luis Machado wrote:

> A bisect confirmed commit e7e1f2034567207e5e01cb75ea2ffd568a64e84d changed the
> gdb.python/py-parameter.exp behavior from PASS to FAIL.
> gdb.python/py-format.exp was failing before.
> 
> I've attached the relevant gdb.log and gdb.sum.
> 
> I don't fully understand the issue here, so I can't be sure this is a real
> regression or something that was broken before but this patch just happened to
> uncover it.

 Thanks.  There is this error:

Traceback (most recent call last):
  File "<string>", line 5, in <module>
  File "<string>", line 4, in __init__
RuntimeError: Range exceeded.
Error while executing Python code.
(gdb) PASS: gdb.python/py-parameter.exp: test_integer_parameter: kind=PARAM_UINTEGER: create parameter: input 7: end

in creating the parameter earlier on and consequently all the subsequent 
tests on the parameter fail.  I think the case above shouldn't score as a 
PASS either; pattern matching must be too liberal here.

 The situation here is previously only parameters of the PARAM_ZUINTEGER 
and PARAM_ZUINTEGER_UNLIMITED types were tested.  Now we also test ones of 
the PARAM_UINTEGER, PARAM_INTEGER, and PARAM_ZINTEGER types, so it is a 
new test that is failing.  Parameter of all the types are initialised to 
0, which is permitted either as itself or as the "unlimited" value.  For 
the failing PARAM_UINTEGER case it means "unlimited".  So wonder where 
this range error is coming from really, hmm...

 You don't happen to have any local patches applied, do you?  Also what 
version of Python?

  Maciej

  reply	other threads:[~2022-10-31 13:09 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 22:03 [PATCH v6 0/8] gdb: split array and string limiting options Maciej W. Rozycki
2022-08-17 22:03 ` [PATCH v6 1/8] GDB/Guile: Don't assert that an integer value is boolean Maciej W. Rozycki
2022-10-17 13:43   ` Simon Marchi
2022-10-21  7:58     ` Maciej W. Rozycki
2022-10-21 18:44   ` Simon Marchi
2022-10-21 20:54     ` Maciej W. Rozycki
2022-10-22  0:48       ` Simon Marchi
2022-08-17 22:03 ` [PATCH v6 2/8] GDB/doc: Document the Guile `#:unlimited' keyword Maciej W. Rozycki
2022-08-18  6:06   ` Eli Zaretskii
2022-09-01 10:31     ` Maciej W. Rozycki
2022-08-17 22:04 ` [PATCH v6 3/8] GDB/testsuite: Expand Python integer parameter coverage across all types Maciej W. Rozycki
2022-10-17 13:56   ` Simon Marchi
2022-10-21  7:59     ` Maciej W. Rozycki
2022-08-17 22:04 ` [PATCH v6 4/8] GDB/Python: Make `None' stand for `unlimited' in setting integer parameters Maciej W. Rozycki
2022-10-17 14:26   ` Simon Marchi
2022-10-21  8:03     ` Maciej W. Rozycki
2022-08-17 22:04 ` [PATCH v6 5/8] GDB/Python: Use None for `var_zuinteger_unlimited' value set to `unlimited' Maciej W. Rozycki
2022-08-18  6:08   ` Eli Zaretskii
2022-10-17 15:02   ` Simon Marchi
2022-10-29 15:58     ` Maciej W. Rozycki
2022-10-31 13:00       ` Simon Marchi
2022-10-31 13:31         ` Maciej W. Rozycki
2022-11-01 12:28           ` Maciej W. Rozycki
2022-10-26 11:58   ` Luis Machado
2022-10-29 13:52     ` Maciej W. Rozycki
2022-10-31  8:14       ` Luis Machado
2022-10-31 12:37         ` Luis Machado
2022-10-31 13:08           ` Maciej W. Rozycki [this message]
2022-10-31 13:14             ` Luis Machado
2022-10-31 14:05               ` Maciej W. Rozycki
2022-08-17 22:04 ` [PATCH v6 6/8] GDB: Allow arbitrary keywords in integer set commands Maciej W. Rozycki
2022-08-17 22:05 ` [PATCH v6 7/8] GDB: Add a character string limiting option Maciej W. Rozycki
2022-08-17 22:05 ` [PATCH v6 8/8] GDB/testsuite: Expand for character string limiting options Maciej W. Rozycki
2022-08-18  0:07   ` [PATCH v6.1 " Maciej W. Rozycki
2022-09-01 10:32 ` [PING][PATCH v6 0/8] gdb: split array and " Maciej W. Rozycki
2022-09-08  9:37 ` [PING^2][PATCH " Maciej W. Rozycki
2022-09-14 17:43 ` [PING^3][PATCH " Maciej W. Rozycki
2022-09-22 22:07 ` [PING^4][PATCH " Maciej W. Rozycki
2022-09-29  7:09 ` [PING^5][PATCH " Maciej W. Rozycki
2022-09-29  7:12   ` Simon Sobisch
2022-10-06 15:46 ` [PING^6][PATCH " Maciej W. Rozycki
2022-10-12 21:19 ` [PING^7][PATCH " Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.2210311248540.19931@tpp.orcam.me.uk \
    --to=macro@embecosm.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@arm.com \
    --cc=simonsobisch@web.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).